Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 3c00e4a10afac5959e7ad7e89b67801980ffcf6d..c31b76fa100cee3e7ba88abb14d5856e70a4a186 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -64,12 +64,6 @@ class CONTENT_EXPORT NavigationHandle {
// * using window.history.pushState
virtual bool IsRendererInitiated() = 0;
- // Whether the navigation is synchronous or not. Examples of synchronous
- // navigations are:
- // * reference fragment navigations
- // * pushState/popState
- virtual bool IsSynchronousNavigation() = 0;
-
// Whether the navigation is for an iframe with srcdoc attribute.
virtual bool IsSrcdoc() = 0;
@@ -137,9 +131,10 @@ class CONTENT_EXPORT NavigationHandle {
// called.
virtual RenderFrameHost* GetRenderFrameHost() = 0;
- // Whether the navigation happened in the same page. This is only known
- // after the navigation has committed. It is an error to call this method
- // before the navigation has committed.
+ // Whether the navigation happened in the same page. Examples of same page
+ // navigations are:
+ // * reference fragment navigations
+ // * pushState/replaceState
virtual bool IsSamePage() = 0;
// Whether the navigation has encountered a server redirect or not.

Powered by Google App Engine
This is Rietveld 408576698