Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 3d5d5a12d3dc0b0767ba896ac550628a0a2f634b..f2e9d79e3a998328ba64403565ede9977055764d 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -235,11 +235,10 @@ void NavigationRequest::BeginNavigation() {
void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id) {
// TODO(nasko): Update the NavigationHandle creation to ensure that the
- // proper values are specified for is_synchronous and is_srcdoc.
+ // proper values are specified for is_same_page and is_srcdoc.
navigation_handle_ = NavigationHandleImpl::Create(
- common_params_.url, frame_tree_node_,
- !browser_initiated_,
- false, // is_synchronous
+ common_params_.url, frame_tree_node_, !browser_initiated_,
+ false, // is_same_page
false, // is_srcdoc
common_params_.navigation_start, pending_nav_entry_id);
}

Powered by Google App Engine
This is Rietveld 408576698