Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index c15439bae6a5f3ba61cb5e4f6c807d1dee0754b3..eb1f273e9f0fde8143b38baa35d9a02283a6cba3 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -269,7 +269,7 @@ void WebNavigationTabObserver::RenderFrameHostChanged(
void WebNavigationTabObserver::DidStartNavigation(
content::NavigationHandle* navigation_handle) {
- if (navigation_handle->IsSynchronousNavigation() ||
+ if (navigation_handle->IsSamePage() ||
!FrameNavigationState::IsValidUrl(navigation_handle->GetURL())) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698