Remove IsSynchronous API from NavigationHandle.

chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/captive_portal/captive_portal_tab_helper.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/macros.h"
@@ skipping 13 matching lines @@
 #include "content/public/test/web_contents_tester.h"
 #include "net/base/net_errors.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using captive_portal::CaptivePortalResult;
 using content::ResourceType;
 
 namespace {
 
+const char* const kStartUrl = "http://whatever.com/index.html";
 const char* const kHttpUrl = "http://whatever.com/";
 const char* const kHttpsUrl = "https://whatever.com/";
 
 // Used for cross-process navigations.  Shouldn't actually matter whether this
 // is different from kHttpsUrl, but best to keep things consistent.
 const char* const kHttpsUrl2 = "https://cross_process.com/";
 
 // Some navigations behave differently depending on if they're cross-process
 // or not.
 enum NavigationType {
@@ skipping 23 matching lines @@
 // the harness in any other way.
 class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {
  public:
   CaptivePortalTabHelperTest()
       : mock_reloader_(new testing::StrictMock<MockCaptivePortalTabReloader>) {}
   ~CaptivePortalTabHelperTest() override {}
 
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
 
-    // Load kHttpUrl. This ensures that any subsequent navigation to kHttpsUrl2
+    // Load kStartUrl. This ensures that any subsequent navigation to kHttpsUrl2

[Charlie Reis, 2016/10/27 20:51:24]

Why was this change necessary?  Maybe mention in the comment why kHttpUrl isn't
used?

[nasko, 2016/10/27 21:22:34]

Done.

     // will be properly registered as cross-process.
     content::WebContentsTester* web_contents_tester =
         content::WebContentsTester::For(web_contents());
-    web_contents_tester->NavigateAndCommit(GURL(kHttpUrl));
+    web_contents_tester->NavigateAndCommit(GURL(kStartUrl));
     content::RenderFrameHostTester* rfh_tester =
         content::RenderFrameHostTester::For(main_rfh());
     rfh_tester->SimulateNavigationStop();
 
     tab_helper_.reset(new CaptivePortalTabHelper(web_contents()));
     tab_helper_->profile_ = nullptr;
     tab_helper_->SetTabReloaderForTest(mock_reloader_);
   }
 
   void TearDown() override {
@@ skipping 432 matching lines @@
   EXPECT_FALSE(tab_helper()->IsLoginTab());
 
   ObservePortalResult(captive_portal::RESULT_BEHIND_CAPTIVE_PORTAL,
                       captive_portal::RESULT_NO_RESPONSE);
   EXPECT_FALSE(tab_helper()->IsLoginTab());
 
   ObservePortalResult(captive_portal::RESULT_NO_RESPONSE,
                       captive_portal::RESULT_INTERNET_CONNECTED);
   EXPECT_FALSE(tab_helper()->IsLoginTab());
 }