Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2345053005: Sane use of FcPatternGetXXX in SkFontConfigInterface. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sane use of FcPatternGetXXX in SkFontConfigInterface. This renames get_name to get_string to better reflect what it does, uses get_int where appropriate, and removes the no longer used code that uses FcPatternGetBool. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345053005 Committed: https://skia.googlesource.com/skia/+/875b8f6d35510523b0267e9a78217a91b2484698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 7 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
bungeman-skia
A little bit of boring sanity.
4 years, 3 months ago (2016-09-16 19:57:36 UTC) #8
mtklein_C
lgtm
4 years, 3 months ago (2016-09-16 20:18:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345053005/1
4 years, 3 months ago (2016-09-16 20:18:55 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:19:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/875b8f6d35510523b0267e9a78217a91b2484698

Powered by Google App Engine
This is Rietveld 408576698