Unify mustash display closing code paths.

Unify mustash display closing code paths.

There are currently two ways a display can be closed in mustash. First,
the NDD can update and indicated the display is gone. Second, when
running off device the user can close the platform window. This CL
unifies the two code paths.

When running off device and the platform window calls
PlatformWindowDelegate::OnRequestClose() the request is forwarded to
PlatformScreen. PlatformScreen then tells the NDD to remove the fake
display. The display configuration will update and the display will be
gone. This allows the same display removed code path to get used in all
cases.

This also fixes PlatformScreen not knowing about the user closing a
display.

BUG=641012
Committed: https://crrev.com/0f1a2fab593f627a168e95b1cfec1b241c129133
Cr-Commit-Position: refs/heads/master@{#419563}

[kylechar, 2016-09-16 16:22:38]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-09-16 17:28:49]

https://codereview.chromium.org/2345043003/diff/20001/services/ui/display/pla...
File services/ui/display/platform_screen.h (right):

https://codereview.chromium.org/2345043003/diff/20001/services/ui/display/pla...
services/ui/display/platform_screen.h:41: virtual void
RequestCloseDisplay(int64_t display_id) = 0;
If you're going to go this route, should the destructor be protected?

[sky, 2016-09-16 18:49:21]

I clearly misread what you are doing. LGTM

[kylechar, 2016-09-16 19:16:48]

Thanks sky!

[kylechar, 2016-09-19 18:52:00]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:52:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:54:02]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-09-19 21:15:52]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-09-19 21:15:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2345043003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-09-19 21:16:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:37:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 21:38:41]

Description was changed from

==========
Unify mustash display closing code paths.

There are currently two ways a display can be closed in mustash. First,
the NDD can update and indicated the display is gone. Second, when
running off device the user can close the platform window. This CL
unifies the two code paths.

When running off device and the platform window calls
PlatformWindowDelegate::OnRequestClose() the request is forwarded to
PlatformScreen. PlatformScreen then tells the NDD to remove the fake
display. The display configuration will update and the display will be
gone. This allows the same display removed code path to get used in all
cases.

This also fixes PlatformScreen not knowing about the user closing a
display.

BUG=641012
==========

to

==========
Unify mustash display closing code paths.

There are currently two ways a display can be closed in mustash. First,
the NDD can update and indicated the display is gone. Second, when
running off device the user can close the platform window. This CL
unifies the two code paths.

When running off device and the platform window calls
PlatformWindowDelegate::OnRequestClose() the request is forwarded to
PlatformScreen. PlatformScreen then tells the NDD to remove the fake
display. The display configuration will update and the display will be
gone. This allows the same display removed code path to get used in all
cases.

This also fixes PlatformScreen not knowing about the user closing a
display.

BUG=641012

Committed: https://crrev.com/0f1a2fab593f627a168e95b1cfec1b241c129133
Cr-Commit-Position: refs/heads/master@{#419563}
==========

[commit-bot: I haz the power, 2016-09-19 21:38:42]

Patchset 3 (id:??) landed as
https://crrev.com/0f1a2fab593f627a168e95b1cfec1b241c129133
Cr-Commit-Position: refs/heads/master@{#419563}