Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: components/flags_ui/flags_state.h

Issue 2345033002: Log base::Features in Launch.FlagsAtStartup (Closed)
Patch Set: Clean up test and localize ReportAboutFlagsHistogram{Switches, Features} Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/flags_ui/flags_state.h
diff --git a/components/flags_ui/flags_state.h b/components/flags_ui/flags_state.h
index c7e59be415327483de82f9054c9cc35368934b1f..979c9d6f6ad8b874de8c3041873702b71873b6f2 100644
--- a/components/flags_ui/flags_state.h
+++ b/components/flags_ui/flags_state.h
@@ -79,6 +79,11 @@ class FlagsState {
// about entries that enable/disable base::Feature states.
std::set<std::string> GetSwitchesFromFlags(FlagsStorage* flags_storage);
+ // Reads the state from |flags_storage| and returns the set of command line
+ // flags that correspond to enabled/disabled base::Feature states. Features
Alexei Svitkine (slow) 2016/09/16 20:50:33 It doesn't really return "command line flags". I w
lawrencewu 2016/09/16 21:20:03 Done.
+ // are suffixed with :enabled or :disabled depending on their state.
Alexei Svitkine (slow) 2016/09/16 20:50:33 I would change this sentence to: Feature names ar
lawrencewu 2016/09/16 21:20:03 Done.
+ std::set<std::string> GetFeaturesFromFlags(FlagsStorage* flags_storage);
+
bool IsRestartNeededToCommitChanges();
void SetFeatureEntryEnabled(FlagsStorage* flags_storage,
const std::string& internal_name,

Powered by Google App Engine
This is Rietveld 408576698