Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: components/flags_ui/flags_state.h

Issue 2345033002: Log base::Features in Launch.FlagsAtStartup (Closed)
Patch Set: Update comment and add missing feature to histograms.xml Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/session/user_session_manager.cc ('k') | components/flags_ui/flags_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/flags_ui/flags_state.h
diff --git a/components/flags_ui/flags_state.h b/components/flags_ui/flags_state.h
index c7e59be415327483de82f9054c9cc35368934b1f..17b3b99c5320c2f56232b3130983c3db7cbd55aa 100644
--- a/components/flags_ui/flags_state.h
+++ b/components/flags_ui/flags_state.h
@@ -74,11 +74,16 @@ class FlagsState {
const char* enable_features_flag_name,
const char* disable_features_flag_name);
- // Reads the state from |flags_storage| and returns the set of command line
- // flags that correspond to enabled entries. Does not populate any information
- // about entries that enable/disable base::Feature states.
+ // Reads the state from |flags_storage| and returns a set of strings
+ // corresponding to enabled entries. Does not populate any information about
+ // entries that enable/disable base::Feature states.
std::set<std::string> GetSwitchesFromFlags(FlagsStorage* flags_storage);
+ // Reads the state from |flags_storage| and returns a set of strings
+ // corresponding to enabled/disabled base::Feature states. Feature names are
+ // suffixed with ":enabled" or ":disabled" depending on their state.
+ std::set<std::string> GetFeaturesFromFlags(FlagsStorage* flags_storage);
+
bool IsRestartNeededToCommitChanges();
void SetFeatureEntryEnabled(FlagsStorage* flags_storage,
const std::string& internal_name,
« no previous file with comments | « chrome/browser/chromeos/login/session/user_session_manager.cc ('k') | components/flags_ui/flags_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698