Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: chrome/browser/about_flags.h

Issue 2345033002: Log base::Features in Launch.FlagsAtStartup (Closed)
Patch Set: Update comment and add missing feature to histograms.xml Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.h
diff --git a/chrome/browser/about_flags.h b/chrome/browser/about_flags.h
index 35c643132f96fd852f52a7a683742762278e5235..9df7a7e5f53fe2a98a1fc7c85af1ba06dfe9cdb8 100644
--- a/chrome/browser/about_flags.h
+++ b/chrome/browser/about_flags.h
@@ -88,10 +88,11 @@ void RecordUMAStatistics(flags_ui::FlagsStorage* flags_storage);
base::HistogramBase::Sample GetSwitchUMAId(const std::string& switch_name);
// Sends stats (as UMA histogram) about a set of command line |flags| in
-// a histogram, with an enum value for each flag in |flags|, based on the
-// hash of the flag name.
+// a histogram, with an enum value for each flag in |switches| and |features|,
+// based on the hash of the flag name.
void ReportAboutFlagsHistogram(const std::string& uma_histogram_name,
- const std::set<std::string>& flags);
+ const std::set<std::string>& switches,
+ const std::set<std::string>& features);
namespace testing {
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698