Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2345023003: Use dartfmt on Observatory code (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5967 lines, -5253 lines) Patch
M runtime/observatory/lib/event.dart View 9 chunks +36 lines, -27 lines 0 comments Download
M runtime/observatory/lib/object_graph.dart View 11 chunks +15 lines, -25 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 11 chunks +26 lines, -28 lines 0 comments Download
M runtime/observatory/lib/service_html.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M runtime/observatory/lib/service_io.dart View 2 chunks +4 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/allocation_profile/allocation_profile.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/app/location_manager.dart View 5 chunks +11 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/app/notification.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 23 chunks +241 lines, -193 lines 0 comments Download
M runtime/observatory/lib/src/app/settings.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/app/view_model.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/cli/command.dart View 5 chunks +26 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/cpu_profile/cpu_profile.dart View 17 chunks +46 lines, -49 lines 0 comments Download
M runtime/observatory/lib/src/debugger/debugger_location.dart View 13 chunks +29 lines, -36 lines 0 comments Download
M runtime/observatory/lib/src/elements/allocation_profile.dart View 12 chunks +301 lines, -257 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_allocation_profile.dart View 3 chunks +20 lines, -18 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_instances.dart View 5 chunks +82 lines, -66 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.dart View 6 chunks +48 lines, -39 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.dart View 7 chunks +281 lines, -240 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.dart View 1 17 chunks +208 lines, -168 lines 0 comments Download
M runtime/observatory/lib/src/elements/containers/virtual_collection.dart View 6 chunks +9 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/containers/virtual_tree.dart View 7 chunks +18 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_ref.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 4 chunks +69 lines, -54 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 5 chunks +45 lines, -38 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 8 chunks +34 lines, -34 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile_table.dart View 10 chunks +144 lines, -160 lines 0 comments Download
M runtime/observatory/lib/src/elements/curly_block.dart View 3 chunks +16 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 93 chunks +454 lines, -449 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_ref.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_view.dart View 2 chunks +14 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.dart View 9 chunks +66 lines, -68 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_ref.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.dart View 6 chunks +99 lines, -88 lines 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.dart View 3 chunks +20 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 3 chunks +15 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.dart View 1 6 chunks +184 lines, -150 lines 0 comments Download
M runtime/observatory/lib/src/elements/general_error.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.dart View 8 chunks +31 lines, -32 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 16 chunks +133 lines, -99 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/nav_bar.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/nav_menu.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart View 4 chunks +12 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/tag.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/helpers/uris.dart View 1 chunk +25 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_ref.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.dart View 3 chunks +72 lines, -55 lines 0 comments Download
M runtime/observatory/lib/src/elements/inbound_references.dart View 2 chunks +13 lines, -19 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 11 chunks +46 lines, -37 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.dart View 11 chunks +379 lines, -267 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate/counter_chart.dart View 2 chunks +15 lines, -12 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate/location.dart View 4 chunks +17 lines, -24 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate/run_state.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate/shared_summary.dart View 6 chunks +34 lines, -30 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate/summary.dart View 4 chunks +17 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_reconnect.dart View 3 chunks +20 lines, -15 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_ref.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 5 chunks +138 lines, -104 lines 0 comments Download
M runtime/observatory/lib/src/elements/json_view.dart View 5 chunks +11 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_ref.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.dart View 10 chunks +118 lines, -94 lines 0 comments Download
M runtime/observatory/lib/src/elements/local_var_descriptors_ref.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging.dart View 4 chunks +26 lines, -29 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging_list.dart View 2 chunks +18 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_ref.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.dart View 3 chunks +63 lines, -48 lines 0 comments Download
M runtime/observatory/lib/src/elements/metric/details.dart View 4 chunks +63 lines, -41 lines 0 comments Download
M runtime/observatory/lib/src/elements/metric/graph.dart View 3 chunks +44 lines, -29 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.dart View 4 chunks +54 lines, -45 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/class_menu.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/isolate_menu.dart View 5 chunks +32 lines, -31 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/library_menu.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/menu_item.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/notify.dart View 4 chunks +11 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/notify_event.dart View 8 chunks +53 lines, -56 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/notify_exception.dart View 6 chunks +23 lines, -21 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/refresh.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/top_menu.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/vm_menu.dart View 5 chunks +12 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.dart View 5 chunks +91 lines, -77 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.dart View 3 chunks +34 lines, -31 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_ref.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.dart View 4 chunks +61 lines, -57 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.dart View 3 chunks +40 lines, -33 lines 0 comments Download
M runtime/observatory/lib/src/elements/pc_descriptors_ref.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/persistent_handles.dart View 5 chunks +93 lines, -103 lines 0 comments Download
M runtime/observatory/lib/src/elements/ports.dart View 4 chunks +39 lines, -35 lines 0 comments Download
M runtime/observatory/lib/src/elements/retaining_path.dart View 3 chunks +16 lines, -26 lines 0 comments Download
M runtime/observatory/lib/src/elements/sample_buffer_control.dart View 7 chunks +89 lines, -64 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 42 chunks +186 lines, -168 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_ref.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.dart View 3 chunks +49 lines, -42 lines 0 comments Download
M runtime/observatory/lib/src/elements/sentinel_value.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/sentinel_view.dart View 4 chunks +21 lines, -20 lines 0 comments Download
M runtime/observatory/lib/src/elements/source_inset.dart View 3 chunks +18 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/elements/source_link.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/stack_trace_tree_config.dart View 8 chunks +83 lines, -66 lines 0 comments Download
M runtime/observatory/lib/src/elements/strongly_reachable_instances.dart View 4 chunks +14 lines, -22 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.dart View 9 chunks +93 lines, -77 lines 0 comments Download
M runtime/observatory/lib/src/elements/token_stream_ref.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/top_retaining_instances.dart View 4 chunks +23 lines, -22 lines 0 comments Download
M runtime/observatory/lib/src/elements/type_arguments_ref.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/unknown_ref.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/view_footer.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 8 chunks +33 lines, -23 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect_target.dart View 4 chunks +10 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 3 chunks +87 lines, -54 lines 0 comments Download
M runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart View 8 chunks +28 lines, -28 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/breakpoint.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/class.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/code.dart View 1 chunk +1 line, -7 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/error.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/event.dart View 7 chunks +13 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/field.dart View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/function.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/inbound_references.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/instance.dart View 4 chunks +36 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/isolate.dart View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/library.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/notification.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/objectpool.dart View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/retaining_path.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/sample_profile.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/sentinel.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/source_location.dart View 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/allocation_profile.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/breakpoint.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/class.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/eval.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/field.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/function.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/heap_snapshot.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/isolate.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/megamorphiccache.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/metric.dart View 1 chunk +2 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/repositories/sample_profile.dart View 2 chunks +7 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/repositories/allocation_profile.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/breakpoint.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/class.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/repositories/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/event.dart View 1 chunk +57 lines, -49 lines 0 comments Download
M runtime/observatory/lib/src/repositories/field.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/flag.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/repositories/function.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/heap_snapshot.dart View 7 chunks +8 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/repositories/icdata.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/inbound_references.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/repositories/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/isolate.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/library.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/megamorphiccache.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/metric.dart View 5 chunks +49 lines, -29 lines 0 comments Download
M runtime/observatory/lib/src/repositories/notification.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/repositories/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/objectpool.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/reachable_size.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/repositories/retained_size.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/repositories/retaining_path.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/repositories/sample_profile.dart View 7 chunks +31 lines, -24 lines 0 comments Download
M runtime/observatory/lib/src/repositories/strongly_reachable_instances.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/repositories/target.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/repositories/top_retaining_instances.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 98 chunks +334 lines, -363 lines 0 comments Download
M runtime/observatory/lib/tracer.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/observatory/lib/utils.dart View 5 chunks +36 lines, -27 lines 0 comments Download
A runtime/observatory/tool/ensure_dartfmt.sh View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/web/main.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 3 months ago (2016-09-15 20:54:13 UTC) #3
rmacnak
lgtm
4 years, 3 months ago (2016-09-15 22:01:39 UTC) #4
Cutch
4 years, 3 months ago (2016-09-16 13:59:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7fca076fbbee8c71dee58d13c96ae906bef0045e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698