Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2345023002: Revert of Track frame context URL using first script heuristic (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Track frame context URL using first script heuristic (patchset #7 id:120001 of https://codereview.chromium.org/2296923004/ ) Reason for revert: broke compile: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/93915 c:\b\c\b\win_layout\src\third_party\webkit\source\core\inspector\inspectorwebperfagenttest.cpp(48) : error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win_layout\src\third_party\webkit\source\core\inspector\inspectorwebperfagenttest.cpp(48) : warning C4702: unreachable code Original issue's description: > Track frame context URL using first script heuristic > > BUG=635596 > > Committed: https://crrev.com/7012b38dafd3fcaaeaee7b7413718b4b6d7493ca > Cr-Commit-Position: refs/heads/master@{#418931} TBR=caseq@chromium.org,alph@chromium.org,pfeldman@chromium.org,dgozman@chromium.org,panicker@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635596 Committed: https://crrev.com/57340e50c3c836cad45b2c88e3903ee8f68010b9 Cr-Commit-Position: refs/heads/master@{#418933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -148 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp View 3 chunks +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp View 1 chunk +0 lines, -123 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
msw
Created Revert of Track frame context URL using first script heuristic
4 years, 3 months ago (2016-09-15 19:43:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345023002/1
4 years, 3 months ago (2016-09-15 19:44:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 19:45:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/57340e50c3c836cad45b2c88e3903ee8f68010b9 Cr-Commit-Position: refs/heads/master@{#418933}
4 years, 3 months ago (2016-09-15 19:47:56 UTC) #7
panicker
On 2016/09/15 19:47:56, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 3 months ago (2016-09-16 16:53:13 UTC) #8
msw
4 years, 3 months ago (2016-09-16 17:42:48 UTC) #9
Message was sent while issue was closed.
On 2016/09/16 16:53:13, Shubhie wrote:
> On 2016/09/15 19:47:56, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/57340e50c3c836cad45b2c88e3903ee8f68010b9
> > Cr-Commit-Position: refs/heads/master@{#418933}
> 
> Do you know how I was able to submit this CL in the first place? Does the
> mentioned compile not run as part of pre-submit? is there a bug for this or
> should I file a bug?
> Thanks.

Apparently none of the *default* trybots have the same configuration as "WebKit
Win x64 Builder (dbg)" (swarming_gn_debug_bot_minimal_symbols_x64) *and* build
that same target. It's possible that you could have tried some additional
trybots (click "Choose trybots", under master.tryserver.blink, I see
win7_blink_dbg and win7_blink_compile_dbg that *might* be close, maybe also
something under master.tryserver.chromium.win); here's the configuration info
for the bot that failed, feel free to search for bots with similar configs, you
might want to try you CL as-is with some extra trybots, and ping/file an infra
bug if none catch your error:

https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=670
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bu...
is_component_build = true
is_debug = true
symbol_level = 1
target_cpu = "x64"
use_goma = true

Powered by Google App Engine
This is Rietveld 408576698