Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 23450044: Update dart2js parser to disallow repeated comparisons and prefix +. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Correct arguments for reportError. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/token.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/warnings.dart
diff --git a/sdk/lib/_internal/compiler/implementation/warnings.dart b/sdk/lib/_internal/compiler/implementation/warnings.dart
index bd06786f895183766f130b48cb048047c567f3ec..54cbe3170396ad7e79c245ba4bd45f975fe862a4 100644
--- a/sdk/lib/_internal/compiler/implementation/warnings.dart
+++ b/sdk/lib/_internal/compiler/implementation/warnings.dart
@@ -815,7 +815,7 @@ main() => foo(1);
"removing the 'const' modifier.",
examples: const ["""
void main() {
- const c; // This constant variable must be initialized.
+ const c; // This constant variable must be initialized.
}"""]);
@@ -901,6 +901,9 @@ Error: "#{value}" is not a valid Symbol name because is not:
'Error: "!==" is not an operator. '
'Did you mean "#{lhs} != #{rhs}" or "!identical(#{lhs}, #{rhs})"?');
+ static const MessageKind UNSUPPORTED_PREFIX_PLUS = const MessageKind(
+ 'Error: "+" is not a prefix operator.');
ahe 2013/09/20 08:17:17 Could you add an example and "howToFix"?
Lasse Reichstein Nielsen 2013/09/20 08:26:15 What would a fix be? For "+2" it would just be rem
ahe 2013/09/20 08:33:42 I think something like: "Try removing '+'."
ahe 2013/09/20 08:33:42 Another thing, please use double quotes for the co
+
static const MessageKind UNSUPPORTED_THROW_WITHOUT_EXP = const MessageKind(
'Error: No expression after "throw". '
'Did you mean "rethrow"?');
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/token.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698