Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: Source/bindings/v8/SerializedScriptValue.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptValue.cpp ('k') | Source/bindings/v8/WorkerScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/SerializedScriptValue.cpp
diff --git a/Source/bindings/v8/SerializedScriptValue.cpp b/Source/bindings/v8/SerializedScriptValue.cpp
index 593f6c6785a6bf760609c3d78dbc84ce2bc32749..46a815b2a003f18f0afa8b3fffcb4c8a953b0c1c 100644
--- a/Source/bindings/v8/SerializedScriptValue.cpp
+++ b/Source/bindings/v8/SerializedScriptValue.cpp
@@ -2510,10 +2510,11 @@ v8::Handle<v8::Value> SerializedScriptValue::deserialize(v8::Isolate* isolate, M
ScriptValue SerializedScriptValue::deserializeForInspector(ScriptState* scriptState)
{
- v8::HandleScope handleScope(scriptState->isolate());
+ v8::Isolate* isolate = scriptState->isolate();
+ v8::HandleScope handleScope(isolate);
v8::Context::Scope contextScope(scriptState->context());
- return ScriptValue(deserialize(scriptState->isolate()));
+ return ScriptValue(deserialize(isolate), isolate);
}
void SerializedScriptValue::registerMemoryAllocatedWithCurrentScriptContext()
« no previous file with comments | « Source/bindings/v8/ScriptValue.cpp ('k') | Source/bindings/v8/WorkerScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698