Source/bindings/v8/ScriptPromise.h - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptPromise.h

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptPromise.h

diff --git a/Source/bindings/v8/ScriptPromise.h b/Source/bindings/v8/ScriptPromise.h

index 02f0a227b39aa701b9e539d8c07e953d79d9e451..8ed4f0812ce48ad9022870894c8ff8aee3189c8e 100644

--- a/Source/bindings/v8/ScriptPromise.h

+++ b/Source/bindings/v8/ScriptPromise.h

@@ -56,8 +56,9 @@ public:

ASSERT(!m_promise.hasNoValue());

}

+ // FIXME: This constructor should take an isolate.

explicit ScriptPromise(v8::Handle<v8::Value> promise)

- : m_promise(promise)

+ : m_promise(promise, v8::Isolate::GetCurrent())

{

ASSERT(!m_promise.hasNoValue());

}