Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestMediaQueryListListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index a8f0124f7e769205dd690942673d27aa8fd19499..eb21fe9ffe997155e55ecaeb32fbf8691a22951d 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -5155,7 +5155,7 @@ sub JSValueToNative
if ($type eq "any" || IsCallbackFunctionType($type)) {
AddToImplIncludes("bindings/v8/ScriptValue.h");
- return "ScriptValue($value)";
+ return "ScriptValue($value, $getIsolate)";
}
if ($type eq "Promise") {
@@ -5169,7 +5169,7 @@ sub JSValueToNative
if ($type eq "MediaQueryListListener") {
AddToImplIncludes("core/css/MediaQueryListListener.h");
- return "MediaQueryListListener::create(" . $value . ")";
+ return "MediaQueryListListener::create(ScriptValue(" . $value . ", $getIsolate))";
}
if ($type eq "EventTarget") {
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestMediaQueryListListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698