Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: Source/bindings/v8/ScriptCallStackFactory.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove useless member Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 133
134 PassRefPtr<ScriptArguments> createScriptArguments(const v8::FunctionCallbackInfo <v8::Value>& v8arguments, unsigned skipArgumentCount) 134 PassRefPtr<ScriptArguments> createScriptArguments(const v8::FunctionCallbackInfo <v8::Value>& v8arguments, unsigned skipArgumentCount)
135 { 135 {
136 v8::Isolate* isolate = v8arguments.GetIsolate(); 136 v8::Isolate* isolate = v8arguments.GetIsolate();
137 v8::HandleScope scope(isolate); 137 v8::HandleScope scope(isolate);
138 v8::Local<v8::Context> context = isolate->GetCurrentContext(); 138 v8::Local<v8::Context> context = isolate->GetCurrentContext();
139 ScriptState* state = ScriptState::forContext(context); 139 ScriptState* state = ScriptState::forContext(context);
140 140
141 Vector<ScriptValue> arguments; 141 Vector<ScriptValue> arguments;
142 for (int i = skipArgumentCount; i < v8arguments.Length(); ++i) 142 for (int i = skipArgumentCount; i < v8arguments.Length(); ++i)
143 arguments.append(ScriptValue(v8arguments[i])); 143 arguments.append(ScriptValue(v8arguments[i], isolate));
144 144
145 return ScriptArguments::create(state, arguments); 145 return ScriptArguments::create(state, arguments);
146 } 146 }
147 147
148 } // namespace WebCore 148 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698