Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6014)

Unified Diff: chrome/browser/profile_resetter/resettable_settings_snapshot.h

Issue 23450021: Profile Reset dialog: the new section with detailed feedback information (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed compilation Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profile_resetter/resettable_settings_snapshot.h
diff --git a/chrome/browser/profile_resetter/resettable_settings_snapshot.h b/chrome/browser/profile_resetter/resettable_settings_snapshot.h
index 9fcf1cb99fdf2de5609dda5c41e124812162c3fc..f4ac1610c12283faa12cd51ebe28c720bda40fa1 100644
--- a/chrome/browser/profile_resetter/resettable_settings_snapshot.h
+++ b/chrome/browser/profile_resetter/resettable_settings_snapshot.h
@@ -8,10 +8,15 @@
#include "base/basictypes.h"
#include "chrome/browser/prefs/session_startup_pref.h"
+namespace base {
+class ListValue;
+}
+
// ResettableSettingsSnapshot captures some settings values at constructor. It
// can calculate the difference between two snapshots. That is, modified fields.
class ResettableSettingsSnapshot {
public:
+ typedef std::vector<std::pair<std::string, std::string> > ExtensionList;
battre 2013/09/12 14:03:14 Can you please describe the components of the pair
vasilii 2013/09/16 13:58:02 Done.
// All types of settings handled by this class.
enum Field {
STARTUP_URLS = 1 << 0,
@@ -39,7 +44,7 @@ class ResettableSettingsSnapshot {
const std::string& dse_url() const { return dse_url_; }
- const std::vector<std::string>& enabled_extensions() const {
+ const ExtensionList& enabled_extensions() const {
return enabled_extensions_;
}
@@ -65,8 +70,8 @@ class ResettableSettingsSnapshot {
// Default search engine.
std::string dse_url_;
- // Enabled extension ids. Always sorted.
- std::vector<std::string> enabled_extensions_;
+ // List of pairs [id, name] for enabled extensions. Always sorted.
+ ExtensionList enabled_extensions_;
DISALLOW_COPY_AND_ASSIGN(ResettableSettingsSnapshot);
};
@@ -80,4 +85,8 @@ std::string SerializeSettingsReport(const ResettableSettingsSnapshot& snapshot,
// SerializeSettingsReport().
void SendSettingsFeedback(const std::string& report, Profile* profile);
+// Returns list of key/value pairs for all reported information from the
+// |profile| and some additional fields.
+base::ListValue* GetReadableFeedback(Profile* profile);
+
#endif // CHROME_BROWSER_PROFILE_RESETTER_RESETTABLE_SETTINGS_SNAPSHOT_H_

Powered by Google App Engine
This is Rietveld 408576698