Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 23450020: ccameron's https://codereview.chromium.org/23191007 with some changes to work (Closed)

Created:
7 years, 3 months ago by sadrul
Modified:
5 years, 10 months ago
CC:
chromium-reviews, sadrul, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -9 lines) Patch
M base/message_loop/message_loop.h View 1 2 3 4 5 6 5 chunks +19 lines, -1 line 0 comments Download
M base/message_loop/message_loop.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M base/message_loop/message_pump_x11.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_x11.cc View 1 2 3 4 5 6 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 2 3 4 5 4 chunks +64 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
This seems to build+run OK for me. The fist CL in this series: https://codereview.chromium.org/23537016/ the ...
7 years, 3 months ago (2013-09-05 14:36:07 UTC) #1
ccameron
7 years, 3 months ago (2013-09-05 16:51:37 UTC) #2
Thanks!!

These and the others lg for me. I can take over the gl_surface_glx parts of this
(cause they need some work), but the rest can go in as-is (well, OWNER reviews
and all that).

It looks like this sequence is doing the reverse of the change I was making --
instead of having the GTK observers derive from a different (from
MessageLoop::Observer) type, we're having the NativeViewXExposeEventForwarder
class derive from a non-MessageLoop::Observer type. Seems perfectly reasonable
to me.

Powered by Google App Engine
This is Rietveld 408576698