test launcher: Fix running a single test using filter.

test launcher: Fix running a single test using filter.

BUG=285398
R=phajdan.jr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221308

[Paweł Hajdan Jr., 2013-09-04 21:41:39]

Just two small comments.

Thanks a lot for fixing this!

https://codereview.chromium.org/23450018/diff/1/base/test/test_launcher.cc
File base/test/test_launcher.cc (right):

https://codereview.chromium.org/23450018/diff/1/base/test/test_launcher.cc#ne...
base/test/test_launcher.cc:425: Bind(&ResultsPrinter::AddTestResult,
printer->GetWeakPtr())));
This shouldn't be a weak pointer and should crash to fail loudly.

https://codereview.chromium.org/23450018/diff/1/base/test/test_launcher.cc#ne...
base/test/test_launcher.cc:437: printer->GetWeakPtr()));
nit: Does this fit on the previous line?

[sadrul, 2013-09-04 21:46:36]

https://codereview.chromium.org/23450018/diff/1/base/test/test_launcher.cc
File base/test/test_launcher.cc (right):

https://codereview.chromium.org/23450018/diff/1/base/test/test_launcher.cc#ne...
base/test/test_launcher.cc:425: Bind(&ResultsPrinter::AddTestResult,
printer->GetWeakPtr())));
On 2013/09/04 21:41:39, Paweł Hajdan Jr. wrote:
> This shouldn't be a weak pointer and should crash to fail loudly.

Reverted this change.

https://codereview.chromium.org/23450018/diff/1/base/test/test_launcher.cc#ne...
base/test/test_launcher.cc:437: printer->GetWeakPtr()));
On 2013/09/04 21:41:39, Paweł Hajdan Jr. wrote:
> nit: Does this fit on the previous line?

Yep. Done.

[Paweł Hajdan Jr., 2013-09-04 21:47:08]

LGTM

[commit-bot: I haz the power, 2013-09-04 21:55:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sadrul@chromium.org/23450018/6001

[commit-bot: I haz the power, 2013-09-04 23:06:27]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[sadrul, 2013-09-04 23:57:06]

Committed patchset #2 manually as r221308 (presubmit successful).