Make NetworkList and NetworkMonitor APIs public

Make NetworkList and NetworkMonitor APIs public

BUG=281781
R=nfullagar@chromium.org, thakis@chromium.org, yzshen@chromium.org
TBR=cevans@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224626

[yzshen1, 2013-08-30 17:31:45]

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
File ppapi/api/ppb_network_list.idl (right):

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
ppapi/api/ppb_network_list.idl:1: /* Copyright (c) 2012 The Chromium Authors.
All rights reserved.
nit: 2013.

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
ppapi/api/ppb_network_list.idl:50: PP_NETWORKLIST_DOWN = 0,
- Both enum has PP_NETWORKLIST_ prefix. Shall we use PP_NETWORKLISTTYPE_ and
PP_NETWORKLISTSTATE_?

- It seems that they are "network interface" type and state, instead of "network
list" type and state, right?

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
ppapi/api/ppb_network_list.idl:151: * specified <code>index</code>.
It seems good to comment about the failure output. (undefined var?)

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
File ppapi/api/ppb_network_monitor.idl (right):

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
ppapi/api/ppb_network_monitor.idl:1: /* Copyright (c) 2012 The Chromium Authors.
All rights reserved.
nit: 2013

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
ppapi/api/ppb_network_monitor.idl:31: * Starts network change monitoring. The
specified
There were discussions about how event notifications should be done. And people
think that the preferred way is to do something like this:

// Create() doesn't take a callback.
PP_Resource Create(PP_Instance);

// Monitor() returns with the next change event. If you would like to 
// continue monitoring, call Monitor() again when |callback| is run.
int32_t MonitorNetworkListChange([in] PP_Resource network_monitor,
                                 [out] PP_Resource* network_list,
                                 [in] PP_CompletionCallback callback);

Besides, in order to get the initial network list, we can either define that the
first call to MonitorNetworkListChange() after the resource is created returns
the current network list. Or we have to provide another method:

int32_t GetNetworkList([in] PP_Resource network_monitor,
                       [out] PP_Resource* network_list,
                       [in] PP_CompletionCallback callback);

What do you think?

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
ppapi/api/ppb_network_monitor.idl:32: * <code>callback</code> will be called on
the main thread once
We should issue the callback on the thread where Create() is called. (If we
decide not to change this interface according to my previous comment.)

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/private/ppb_netw...
File ppapi/api/private/ppb_network_monitor_private.idl (left):

https://codereview.chromium.org/23450012/diff/3001/ppapi/api/private/ppb_netw...
ppapi/api/private/ppb_network_monitor_private.idl:11: M19 = 0.2
Usually we need to keep the old, private API for a while, until we are sure
nobody is using it.
Have you confirmed that it is not needed by anyone?

[Sergey Ulanov, 2013-08-30 19:02:25]

I'm going to split this CL: I'll refactor private interfaces in place before
moving them out of Private.

On 2013/08/30 17:31:45, yzshen1 wrote:
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
> File ppapi/api/ppb_network_list.idl (right):
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
> ppapi/api/ppb_network_list.idl:1: /* Copyright (c) 2012 The Chromium Authors.
> All rights reserved.
> nit: 2013.
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
> ppapi/api/ppb_network_list.idl:50: PP_NETWORKLIST_DOWN = 0,
> - Both enum has PP_NETWORKLIST_ prefix. Shall we use PP_NETWORKLISTTYPE_ and
> PP_NETWORKLISTSTATE_?
> 
> - It seems that they are "network interface" type and state, instead of
"network
> list" type and state, right?
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list...
> ppapi/api/ppb_network_list.idl:151: * specified <code>index</code>.
> It seems good to comment about the failure output. (undefined var?)
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
> File ppapi/api/ppb_network_monitor.idl (right):
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
> ppapi/api/ppb_network_monitor.idl:1: /* Copyright (c) 2012 The Chromium
Authors.
> All rights reserved.
> nit: 2013
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
> ppapi/api/ppb_network_monitor.idl:31: * Starts network change monitoring. The
> specified
> There were discussions about how event notifications should be done. And
people
> think that the preferred way is to do something like this:
> 
> // Create() doesn't take a callback.
> PP_Resource Create(PP_Instance);
> 
> // Monitor() returns with the next change event. If you would like to 
> // continue monitoring, call Monitor() again when |callback| is run.
> int32_t MonitorNetworkListChange([in] PP_Resource network_monitor,
>                                  [out] PP_Resource* network_list,
>                                  [in] PP_CompletionCallback callback);
> 
> Besides, in order to get the initial network list, we can either define that
the
> first call to MonitorNetworkListChange() after the resource is created returns
> the current network list. Or we have to provide another method:
> 
> int32_t GetNetworkList([in] PP_Resource network_monitor,
>                        [out] PP_Resource* network_list,
>                        [in] PP_CompletionCallback callback);
> 
> What do you think?
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_moni...
> ppapi/api/ppb_network_monitor.idl:32: * <code>callback</code> will be called
on
> the main thread once
> We should issue the callback on the thread where Create() is called. (If we
> decide not to change this interface according to my previous comment.)
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/private/ppb_netw...
> File ppapi/api/private/ppb_network_monitor_private.idl (left):
> 
>
https://codereview.chromium.org/23450012/diff/3001/ppapi/api/private/ppb_netw...
> ppapi/api/private/ppb_network_monitor_private.idl:11: M19 = 0.2
> Usually we need to keep the old, private API for a while, until we are sure
> nobody is using it.
> Have you confirmed that it is not needed by anyone?

[yzshen1, 2013-08-30 19:07:48]

We probably still need to keep the existing version of private API for a
while.

Maybe we could consider refactoring the internal implementation so that it
supports both the (existing) private API and the new stable API, without
changing the private API?




On Fri, Aug 30, 2013 at 12:02 PM, <sergeyu@chromium.org> wrote:

> Reviewers: yzshen1,
>
> Message:
> I'm going to split this CL: I'll refactor private interfaces in place
> before
> moving them out of Private.
>
>
> On 2013/08/30 17:31:45, yzshen1 wrote:
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_list.idl<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list.idl>
>
>> File ppapi/api/ppb_network_list.idl (right):
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_list.idl#**newcode1<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list.idl#newcode1>
>
>> ppapi/api/ppb_network_list.**idl:1: /* Copyright (c) 2012 The Chromium
>> Authors.
>> All rights reserved.
>> nit: 2013.
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_list.idl#**newcode50<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list.idl#newcode50>
>
>> ppapi/api/ppb_network_list.**idl:50: PP_NETWORKLIST_DOWN = 0,
>> - Both enum has PP_NETWORKLIST_ prefix. Shall we use PP_NETWORKLISTTYPE_
>> and
>> PP_NETWORKLISTSTATE_?
>>
>
>  - It seems that they are "network interface" type and state, instead of
>>
> "network
>
>> list" type and state, right?
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_list.idl#**newcode151<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_list.idl#newcode151>
>
>> ppapi/api/ppb_network_list.**idl:151: * specified <code>index</code>.
>> It seems good to comment about the failure output. (undefined var?)
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_monitor.idl<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_monitor.idl>
>
>> File ppapi/api/ppb_network_monitor.**idl (right):
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_monitor.idl#**newcode1<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_monitor.idl#newcode1>
>
>> ppapi/api/ppb_network_monitor.**idl:1: /* Copyright (c) 2012 The Chromium
>>
> Authors.
>
>> All rights reserved.
>> nit: 2013
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_monitor.idl#**newcode31<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_monitor.idl#newcode31>
>
>> ppapi/api/ppb_network_monitor.**idl:31: * Starts network change
>> monitoring. The
>> specified
>> There were discussions about how event notifications should be done. And
>>
> people
>
>> think that the preferred way is to do something like this:
>>
>
>  // Create() doesn't take a callback.
>> PP_Resource Create(PP_Instance);
>>
>
>  // Monitor() returns with the next change event. If you would like to
>> // continue monitoring, call Monitor() again when |callback| is run.
>> int32_t MonitorNetworkListChange([in] PP_Resource network_monitor,
>>                                   [out] PP_Resource* network_list,
>>                                   [in] PP_CompletionCallback callback);
>>
>
>  Besides, in order to get the initial network list, we can either define
>> that
>>
> the
>
>> first call to MonitorNetworkListChange() after the resource is created
>> returns
>> the current network list. Or we have to provide another method:
>>
>
>  int32_t GetNetworkList([in] PP_Resource network_monitor,
>>                         [out] PP_Resource* network_list,
>>                         [in] PP_CompletionCallback callback);
>>
>
>  What do you think?
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/ppb_network_monitor.idl#**newcode32<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/ppb_network_monitor.idl#newcode32>
>
>> ppapi/api/ppb_network_monitor.**idl:32: * <code>callback</code> will be
>> called
>>
> on
>
>> the main thread once
>> We should issue the callback on the thread where Create() is called. (If
>> we
>> decide not to change this interface according to my previous comment.)
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/private/ppb_network_**monitor_private.idl<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/private/ppb_network_monitor_private.idl>
>
>> File ppapi/api/private/ppb_network_**monitor_private.idl (left):
>>
>
>
> https://codereview.chromium.**org/23450012/diff/3001/ppapi/**
>
api/private/ppb_network_**monitor_private.idl#oldcode11<https://codereview.chromium.org/23450012/diff/3001/ppapi/api/private/ppb_network_monitor_private.idl#oldcode11>
>
>> ppapi/api/private/ppb_network_**monitor_private.idl:11: M19 = 0.2
>> Usually we need to keep the old, private API for a while, until we are
>> sure
>> nobody is using it.
>> Have you confirmed that it is not needed by anyone?
>>
>
>
>
> Description:
> Make NetworkList and NetworkMonitor APIs public
>
> BUG=281781
>
> Please review this at
https://codereview.chromium.**org/23450012/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M native_client_sdk/src/**libraries/ppapi/library.dsc
>   M native_client_sdk/src/**libraries/ppapi_cpp/library.**dsc
>   A ppapi/api/ppb_network_list.idl
>   A + ppapi/api/ppb_network_monitor.**idl
>   D ppapi/api/private/ppb_network_**list_private.idl
>   D ppapi/api/private/ppb_network_**monitor_private.idl
>   M ppapi/c/pp_macros.h
>   A ppapi/c/ppb_network_list.h
>   A + ppapi/c/ppb_network_monitor.h
>   D ppapi/c/private/ppb_network_**list_private.h
>   D ppapi/c/private/ppb_network_**monitor_private.h
>   A + ppapi/cpp/network_list.h
>   A ppapi/cpp/network_list.cc
>   A ppapi/cpp/network_monitor.h
>   A + ppapi/cpp/network_monitor.cc
>   D ppapi/cpp/private/network_**list_private.h
>   D ppapi/cpp/private/network_**list_private.cc
>   D ppapi/cpp/private/network_**monitor_private.h
>   D ppapi/cpp/private/network_**monitor_private.cc
>   M ppapi/native_client/src/**untrusted/pnacl_irt_shim/**pnacl_shim.c
>   M ppapi/ppapi_proxy.gypi
>   M ppapi/ppapi_shared.gypi
>   M ppapi/ppapi_sources.gypi
>   D ppapi/proxy/ppb_network_**monitor_private_proxy.h
>   D ppapi/proxy/ppb_network_**monitor_private_proxy.cc
>   A + ppapi/proxy/ppb_network_**monitor_proxy.h
>   A + ppapi/proxy/ppb_network_**monitor_proxy.cc
>   D ppapi/shared_impl/ppb_network_**list_private_shared.h
>   D ppapi/shared_impl/ppb_network_**list_private_shared.cc
>   A + ppapi/shared_impl/ppb_network_**list_shared.h
>   A + ppapi/shared_impl/ppb_network_**list_shared.cc
>   A + ppapi/tests/test_network_**monitor.cc
>   D ppapi/tests/test_network_**monitor_private.cc
>   M ppapi/thunk/ppb_network_list_**api.h
>   D ppapi/thunk/ppb_network_list_**private_thunk.cc
>   A + ppapi/thunk/ppb_network_list_**thunk.cc
>   D ppapi/thunk/ppb_network_**monitor_private_api.h
>   D ppapi/thunk/ppb_network_**monitor_private_thunk.cc
>   M ppapi/thunk/resource_creation_**api.h
>   D ppapi/utility/private/network_**list_observer_private.h
>   D ppapi/utility/private/network_**list_observer_private.cc
>   M remoting/client/plugin/pepper_**network_manager.h
>   M remoting/client/plugin/pepper_**network_manager.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2013-08-30 19:45:45]

On Fri, Aug 30, 2013 at 12:07 PM, Yuzhu Shen <yzshen@chromium.org> wrote:

> We probably still need to keep the existing version of private API for a
> while.
>

> Maybe we could consider refactoring the internal implementation so that it
> supports both the (existing) private API and the new stable API, without
> changing the private API?
>

This interface is used only by Chromoting client plugin which is built in
into chrome, so I don't think we need to worry about backward compatibility.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yzshen, 2013-08-30 21:20:56]

> This interface is used only by Chromoting client plugin which is built in
> into chrome, so I don't think we need to worry about backward compatibility.
>

Cool!




-- 
Best regards,
Yuzhu Shen.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2013-09-09 18:35:50]

This should be ready for review now. It applies on top of
crrev.com/23819033 and crrev.com/23703008 .
thakis@, please approve chrome/browser/component_updater/ppapi_utils.cc
nfullagar@ - native_client_sdk/src/libraries/*
yzhsen@ - the rest.

[Sergey Ulanov, 2013-09-17 20:01:45]

ping

[Nico, 2013-09-17 20:28:54]

(ppapi_utils.cc lgtm, I was mostly waiting for yzshen to bless the whole CL
first. but since most of it is in ppapi/ I guess I won't accidentally approve
the whole thing with my lg.)

[yzshen1, 2013-09-19 07:56:12]

Only some nits. Sorry for the delay.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_lis...
File ppapi/api/ppb_network_list.idl (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_lis...
ppapi/api/ppb_network_list.idl:113: [in] uint32_t index);
wrong indent.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_lis...
ppapi/api/ppb_network_list.idl:127: [in] uint32_t index);
wrong indent.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_mon...
File ppapi/api/ppb_network_monitor.idl (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_mon...
ppapi/api/ppb_network_monitor.idl:19: * configuration and monitor network
configuration changes.
Please talk about permission. As an example, you could take a look at the
comment of PPB_TCPSocket.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_mon...
ppapi/api/ppb_network_monitor.idl:63: * otherwise.
nit: merge to the previous line?

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc
File ppapi/cpp/network_list.cc (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc...
ppapi/cpp/network_list.cc:18: template <> const char*
interface_name<PPB_NetworkList>() {
Please append version number explicitly.
(here and below.)

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc...
ppapi/cpp/network_list.cc:23: struct ResourceArray {
This is not needed.

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc...
ppapi/cpp/network_list.cc:28: void* AllocateResourceArray(void* data, uint32_t
count, uint32_t size) {
This is not needed.

https://codereview.chromium.org/23450012/diff/44001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/proxy/ppapi_message...
ppapi/proxy/ppapi_messages.h:90: IPC_ENUM_TRAITS(PP_NetworkList_State)
Please use IPC_ENUM_TRAITS_MAX_VALUE

https://codereview.chromium.org/23450012/diff/44001/ppapi/proxy/ppapi_message...
ppapi/proxy/ppapi_messages.h:91: IPC_ENUM_TRAITS(PP_NetworkList_Type)
Ditto.

[Sergey Ulanov, 2013-09-20 01:17:55]

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_lis...
File ppapi/api/ppb_network_list.idl (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_lis...
ppapi/api/ppb_network_list.idl:113: [in] uint32_t index);
On 2013/09/19 07:56:12, yzshen1 wrote:
> wrong indent.

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_lis...
ppapi/api/ppb_network_list.idl:127: [in] uint32_t index);
On 2013/09/19 07:56:12, yzshen1 wrote:
> wrong indent.

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_mon...
File ppapi/api/ppb_network_monitor.idl (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_mon...
ppapi/api/ppb_network_monitor.idl:19: * configuration and monitor network
configuration changes.
On 2013/09/19 07:56:12, yzshen1 wrote:
> Please talk about permission. As an example, you could take a look at the
> comment of PPB_TCPSocket.

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/api/ppb_network_mon...
ppapi/api/ppb_network_monitor.idl:63: * otherwise.
On 2013/09/19 07:56:12, yzshen1 wrote:
> nit: merge to the previous line?

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc
File ppapi/cpp/network_list.cc (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc...
ppapi/cpp/network_list.cc:18: template <> const char*
interface_name<PPB_NetworkList>() {
On 2013/09/19 07:56:12, yzshen1 wrote:
> Please append version number explicitly.
> (here and below.)

Done. Sorry, poorly executed merge.

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc...
ppapi/cpp/network_list.cc:23: struct ResourceArray {
On 2013/09/19 07:56:12, yzshen1 wrote:
> This is not needed.

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/cpp/network_list.cc...
ppapi/cpp/network_list.cc:28: void* AllocateResourceArray(void* data, uint32_t
count, uint32_t size) {
On 2013/09/19 07:56:12, yzshen1 wrote:
> This is not needed.

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

https://codereview.chromium.org/23450012/diff/44001/ppapi/proxy/ppapi_message...
ppapi/proxy/ppapi_messages.h:90: IPC_ENUM_TRAITS(PP_NetworkList_State)
On 2013/09/19 07:56:12, yzshen1 wrote:
> Please use IPC_ENUM_TRAITS_MAX_VALUE 

Done.

https://codereview.chromium.org/23450012/diff/44001/ppapi/proxy/ppapi_message...
ppapi/proxy/ppapi_messages.h:91: IPC_ENUM_TRAITS(PP_NetworkList_Type)
On 2013/09/19 07:56:12, yzshen1 wrote:
> Ditto.

Done.

[yzshen1, 2013-09-20 17:03:01]

LGTM

Thanks!

[nfullagar1, 2013-09-20 19:38:02]

lgtm (native_client_sdk)

[commit-bot: I haz the power, 2013-09-20 19:45:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23450012/72001

[commit-bot: I haz the power, 2013-09-20 20:22:10]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sergey Ulanov, 2013-09-20 21:27:40]

+cevans@ in TBR for trivial change in ppapi_messages.h

[commit-bot: I haz the power, 2013-09-20 21:28:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23450012/72001

[commit-bot: I haz the power, 2013-09-20 22:48:16]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-20 23:53:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23450012/72001

[commit-bot: I haz the power, 2013-09-21 02:51:20]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Sergey Ulanov, 2013-09-22 06:34:14]

Committed patchset #9 manually as r224626 (presubmit successful).