Add encoding tests to pkg/http.

pkg/http/test/request_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library request_test;
 
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:http/http.dart' as http;
@@ skipping 118 matching lines @@
       request.body = "hello";
       expect(request.body, equals("hello"));
     });
 
     test('changes when bodyBytes changes', () {
       var request = new http.Request('POST', dummyUrl);
       request.bodyBytes = [104, 101, 108, 108, 111];
       expect(request.body, equals("hello"));
     });
 
-    // TODO(nweiz): test that both the getter and the setter respect #encoding
-    // when issue 6284 is fixed.
+    test('is encoded according to the given encoding', () {
+      var request = new http.Request('POST', dummyUrl);
+      request.encoding = LATIN1;
+      request.body = "föøbãr";
+      expect(request.bodyBytes, equals([102, 246, 248, 98, 227, 114]));
+    });
+
+    test('is decoded according to the given encoding', () {
+      var request = new http.Request('POST', dummyUrl);
+      request.encoding = LATIN1;
+      request.bodyBytes = [102, 246, 248, 98, 227, 114];
+      expect(request.body, equals("föøbãr"));
+    });
   });
 
   group('#bodyFields', () {
     test("can't be read without setting the content-type", () {
       var request = new http.Request('POST', dummyUrl);
       expect(() => request.bodyFields, throwsStateError);
     });
 
     test("can't be read with the wrong content-type", () {
       var request = new http.Request('POST', dummyUrl);
@@ skipping 22 matching lines @@
 
     test('changes when body changes', () {
       var request = new http.Request('POST', dummyUrl);
       request.headers[HttpHeaders.CONTENT_TYPE] =
           'application/x-www-form-urlencoded';
       request.body = 'key%201=value&key+2=other%2bvalue';
       expect(request.bodyFields,
           equals({'key 1': 'value', 'key 2': 'other+value'}));
     });
 
-    // TODO(nweiz): test that both the getter and the setter respect #encoding
-    // when issue 6284 is fixed.
+    test('is encoded according to the given encoding', () {
+      var request = new http.Request('POST', dummyUrl);
+      request.headers[HttpHeaders.CONTENT_TYPE] =
+          'application/x-www-form-urlencoded';
+      request.encoding = LATIN1;
+      request.bodyFields = {"föø": "bãr"};
+      expect(request.body, equals('f%F6%F8=b%E3r'));
+    });
+
+    test('is decoded according to the given encoding', () {
+      var request = new http.Request('POST', dummyUrl);
+      request.headers[HttpHeaders.CONTENT_TYPE] =
+          'application/x-www-form-urlencoded';
+      request.encoding = LATIN1;
+      request.body = 'f%F6%F8=b%E3r';
+      expect(request.bodyFields, equals({"föø": "bãr"}));
+    });
   });
 
   test('#followRedirects', () {
     print("This test is known to be flaky, please ignore "
           "(debug prints below added by sgjesse@)");
     print("#followRedirects test starting server...");
     expect(startServer().then((_) {
       print("#followRedirects test server running");
 
       var request = new http.Request('POST', serverUrl.resolve('/redirect'))
@@ skipping 195 matching lines @@
   });
 
   group('#toString()', () {
     test('includes the method and URL', () {
       var request = new http.Request('POST', dummyUrl);
       expect(request.toString(), 'POST $dummyUrl');
     });
   });
 }