Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2344993003: [Chromecast] Fade in after a mixer input stream has skipped (Closed)

Created:
4 years, 3 months ago by kmackay
Modified:
4 years, 3 months ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fade in after a mixer input stream has skipped This reduces audio glitches after a stream has skipped (due to the stream not having enough data). BUG= internal b/30747742 Committed: https://crrev.com/128d49991398237586699238759dddaf36b90af8 Cr-Commit-Position: refs/heads/master@{#419084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kmackay
4 years, 3 months ago (2016-09-16 00:23:54 UTC) #2
halliwell
On 2016/09/16 00:23:54, kmackay wrote: lgtm
4 years, 3 months ago (2016-09-16 02:03:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344993003/1
4 years, 3 months ago (2016-09-16 02:19:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 02:54:44 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 02:57:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/128d49991398237586699238759dddaf36b90af8
Cr-Commit-Position: refs/heads/master@{#419084}

Powered by Google App Engine
This is Rietveld 408576698