Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h
diff --git a/third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h b/third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h
index 319d0d331ce75f2fdc0d44c54adf5dbf677e8460..2ca0846da7611f2fac5b5c29cceee3bf1163307e 100644
--- a/third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h
+++ b/third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h
@@ -7,15 +7,16 @@
namespace blink {
+class WebString;
+
// A delegate through which the embedder can trigger events on a Document-bound
// Web Notifications object. Service Worker-bound Web Notifications will not
// have a delegate, as their events will be fired on a Service Worker instead.
class WebNotificationDelegate {
public:
- virtual void dispatchClickEvent() = 0;
- virtual void dispatchShowEvent() = 0;
- virtual void dispatchErrorEvent() = 0;
- virtual void dispatchCloseEvent() = 0;
+ virtual void didShowNotification(const WebString& notificationId) = 0;
+ virtual void didClickNotification() = 0;
+ virtual void didCloseNotification() = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698