Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Unified Diff: content/common/platform_notification_messages.h

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/platform_notification_messages.h
diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h
index 02bb9f3af973da03cc726ee9bb139ced31e5efd8..7646c0ea9ac4f219c76abb2fc2b434f9e8d75401 100644
--- a/content/common/platform_notification_messages.h
+++ b/content/common/platform_notification_messages.h
@@ -71,16 +71,18 @@ IPC_STRUCT_TRAITS_END()
// Messages sent from the browser to the renderer.
// Informs the renderer that the browser has displayed the notification.
-IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidShow,
- int /* notification_id */)
+IPC_MESSAGE_CONTROL2(PlatformNotificationMsg_DidShow,
+ int /* non_persistent_notification_id */,
+ std::string /* notification_id */)
// Informs the renderer that the notification has been closed.
-IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidClose,
- int /* notification_id */)
+IPC_MESSAGE_CONTROL2(PlatformNotificationMsg_DidClose,
+ int /* non_persistent_notification_id */,
+ std::string /* notification_id */)
// Informs the renderer that the notification has been clicked on.
IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidClick,
- int /* notification_id */)
+ int /* non_persistent_notification_id */)
// Reply to PlatformNotificationHostMsg_ShowPersistent indicating that a
// persistent notification has been shown on the platform (if |success| is
@@ -122,9 +124,4 @@ IPC_MESSAGE_CONTROL4(PlatformNotificationHostMsg_GetNotifications,
IPC_MESSAGE_CONTROL3(PlatformNotificationHostMsg_Close,
GURL /* origin */,
std::string /* tag */,
- int /* non_persistent_notification_id */)
-
-IPC_MESSAGE_CONTROL3(PlatformNotificationHostMsg_ClosePersistent,
- GURL /* origin */,
- std::string /* tag */,
std::string /* notification_id */)
« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | third_party/WebKit/Source/modules/notifications/Notification.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698