Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: content/browser/notifications/page_notification_delegate.cc

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/page_notification_delegate.cc
diff --git a/content/browser/notifications/page_notification_delegate.cc b/content/browser/notifications/page_notification_delegate.cc
index 478582917cdc0c915002319794a262bf6d4251f9..6b3b6955904b894781b470b62fba5da96270213c 100644
--- a/content/browser/notifications/page_notification_delegate.cc
+++ b/content/browser/notifications/page_notification_delegate.cc
@@ -26,8 +26,8 @@ void PageNotificationDelegate::NotificationDisplayed() {
if (!sender)
return;
- sender->Send(
- new PlatformNotificationMsg_DidShow(non_persistent_notification_id_));
+ sender->Send(new PlatformNotificationMsg_DidShow(
+ non_persistent_notification_id_, notification_id_));
}
void PageNotificationDelegate::NotificationClosed() {
@@ -35,8 +35,8 @@ void PageNotificationDelegate::NotificationClosed() {
if (!sender)
return;
- sender->Send(
- new PlatformNotificationMsg_DidClose(non_persistent_notification_id_));
+ sender->Send(new PlatformNotificationMsg_DidClose(
+ non_persistent_notification_id_, notification_id_));
static_cast<RenderProcessHostImpl*>(sender)
->notification_message_filter()
« no previous file with comments | « content/browser/notifications/notification_message_filter.cc ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698