Merge the code paths for closing different kinds of notifications.

content/child/notifications/notification_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_NOTIFICATIONS_NOTIFICATION_MANAGER_H_
 #define CONTENT_CHILD_NOTIFICATIONS_NOTIFICATION_MANAGER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 38 matching lines @@
   void showPersistent(
       const blink::WebSecurityOrigin& origin,
       const blink::WebNotificationData& notification_data,
       std::unique_ptr<blink::WebNotificationResources> notification_resources,
       blink::WebServiceWorkerRegistration* service_worker_registration,
       blink::WebNotificationShowCallbacks* callbacks) override;
   void getNotifications(
       const blink::WebString& filter_tag,
       blink::WebServiceWorkerRegistration* service_worker_registration,
       blink::WebNotificationGetCallbacks* callbacks) override;
-  void close(blink::WebNotificationDelegate* delegate) override;
-  void closePersistent(const blink::WebSecurityOrigin& origin,
-                       const blink::WebString& tag,
-                       const blink::WebString& notification_id) override;
+  void close(const blink::WebSecurityOrigin& origin,
+             const blink::WebString& tag,
+             const blink::WebString& notification_id) override;
   void notifyDelegateDestroyed(
       blink::WebNotificationDelegate* delegate) override;
 
   // Called by the NotificationDispatcher.
   bool OnMessageReceived(const IPC::Message& message);
 
  private:
   NotificationManager(ThreadSafeSender* thread_safe_sender,
                       NotificationDispatcher* notification_dispatcher);
 
   // IPC message handlers.
-  void OnDidShow(int notification_id);
+  void OnDidShow(int non_persistent_notification_id,
+                 const std::string& notification_id);
   void OnDidShowPersistent(int request_id, bool success);
-  void OnDidClose(int notification_id);
-  void OnDidClick(int notification_id);
+  void OnDidClose(int non_persistent_notification_id,
+                  const std::string& notification_id);
+  void OnDidClick(int non_persistent_notification_id);
   void OnDidGetNotifications(
       int request_id,
       const std::vector<PersistentNotificationInfo>& notification_infos);
 
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
   scoped_refptr<NotificationDispatcher> notification_dispatcher_;
 
   // Tracks pending requests for getting a list of notifications.
   IDMap<blink::WebNotificationGetCallbacks, IDMapOwnPointer>
       pending_get_notification_requests_;
 
   // Tracks pending requests for displaying persistent notifications.
   IDMap<blink::WebNotificationShowCallbacks, IDMapOwnPointer>
       pending_show_notification_requests_;
 
-  // Structure holding the information for active non-persistent notifications.
-  struct ActiveNotificationData {
-    ActiveNotificationData() = default;
-    ActiveNotificationData(blink::WebNotificationDelegate* delegate,
-                           const GURL& origin,
-                           const std::string& tag);
-    ~ActiveNotificationData();
+  // Map from the notification ID to the associated delegate for non-persistent
+  // notifications, for the purposes of triggering events.
+  std::unordered_map<int, blink::WebNotificationDelegate*>
+      non_persistent_notifications_;
 
-    blink::WebNotificationDelegate* delegate = nullptr;
-    GURL origin;
-    std::string tag;
-  };
-
-  // Map to store the delegate associated with a notification request Id.
-  std::unordered_map<int, ActiveNotificationData> active_page_notifications_;
+  // Association from the notification ID string to the non-persistent
+  // notification ID for non-persistent notifications.
+  std::unordered_map<std::string, int> non_persistent_notification_ids_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_NOTIFICATIONS_NOTIFICATION_MANAGER_H_