Fix color bug in SkRRectsGaussianEdgeShader

Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/ec895345e51e439715f275cc95534d8cc3b1b3e0

[robertphillips, 2016-09-15 18:24:37]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
==========

[robertphillips, 2016-09-15 18:28:07]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
==========

[robertphillips, 2016-09-15 18:28:07]

robertphillips@google.com changed reviewers:
+ jvanverth@google.com

[robertphillips, 2016-09-15 18:29:43]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
==========

[robertphillips, 2016-09-15 18:29:48]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:29:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-09-15 18:43:04]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:43:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 19:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 19:07:43]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-09-15 19:38:45]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[jvanverth1, 2016-09-15 19:52:10]

lgtm + request

https://codereview.chromium.org/2344963002/diff/40001/gm/reveal.cpp
File gm/reveal.cpp (right):

https://codereview.chromium.org/2344963002/diff/40001/gm/reveal.cpp#newcode384
gm/reveal.cpp:384: paint.setShader(SkRRectsGaussianEdgeShader::Make(clipRR,
drawnRR, kPad));
Can this be named something other than kPad? It's a little confusing in this
context.

[robertphillips, 2016-09-15 19:53:20]

https://codereview.chromium.org/2344963002/diff/40001/gm/reveal.cpp
File gm/reveal.cpp (right):

https://codereview.chromium.org/2344963002/diff/40001/gm/reveal.cpp#newcode384
gm/reveal.cpp:384: paint.setShader(SkRRectsGaussianEdgeShader::Make(clipRR,
drawnRR, kPad));
On 2016/09/15 19:52:09, jvanverth1 wrote:
> Can this be named something other than kPad? It's a little confusing in this
> context.

Done.

https://codereview.chromium.org/2344963002/diff/40001/gm/reveal.cpp#newcode384
gm/reveal.cpp:384: paint.setShader(SkRRectsGaussianEdgeShader::Make(clipRR,
drawnRR, kPad));
On 2016/09/15 19:52:09, jvanverth1 wrote:
> Can this be named something other than kPad? It's a little confusing in this
> context.

Done.

[robertphillips, 2016-09-15 19:53:38]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 19:53:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-09-15 20:12:06]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
==========

[robertphillips, 2016-09-15 20:12:24]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
TBR=bsalomon@google.com
==========

[commit-bot: I haz the power, 2016-09-15 20:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:12:25]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-09-15 20:12:44]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-09-15 20:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2344963002/#ps60001
(title: "Add new constant to GM")

[commit-bot: I haz the power, 2016-09-15 20:12:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:15:25]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-09-15 20:16:56]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
TBR=bsalomon@google.com
==========

[robertphillips, 2016-09-15 20:17:04]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-09-15 20:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:18:22]

Description was changed from

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
TBR=bsalomon@google.com
==========

to

==========
Fix color bug in SkRRectsGaussianEdgeShader

Due to the code at the end of emitCode this shader was darker than the
SkGaussianEdgeShader on Android.

This CL also removes the unused "pad" parameter.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002
NOTREECHECKS=true
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/ec895345e51e439715f275cc95534d8cc3b1b3e0
==========

[commit-bot: I haz the power, 2016-09-15 20:18:23]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ec895345e51e439715f275cc95534d8cc3b1b3e0