Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 2344953002: Remove redundant webapk/runtime_library includes in chrome_java_test_support (Closed)

Created:
4 years, 3 months ago by pkotwicz
Modified:
4 years, 3 months ago
Reviewers:
Xi Han, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant webapk/runtime_library includes in chrome_java_test_support These includes are included as part of the runtime_library_javatests target BUG=None Committed: https://crrev.com/ca45a9cb9adbd6d9947ff3d4e0ddb6a548c4872b Cr-Commit-Position: refs/heads/master@{#419350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/test/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pkotwicz
Xi can you please take a look?
4 years, 3 months ago (2016-09-15 18:24:13 UTC) #3
Xi Han
Is it because I added the aidl into the srcjar_deps?
4 years, 3 months ago (2016-09-15 20:25:57 UTC) #4
pkotwicz
Sorry I should have included more explanation. (Putting up CLs with incomplete CL descriptions is ...
4 years, 3 months ago (2016-09-15 21:11:50 UTC) #5
Xi Han
lgtm
4 years, 3 months ago (2016-09-16 12:50:05 UTC) #6
pkotwicz
dfalcantara@ PTAL
4 years, 3 months ago (2016-09-16 15:45:17 UTC) #8
gone
lgtm
4 years, 3 months ago (2016-09-16 17:24:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344953002/1
4 years, 3 months ago (2016-09-16 23:48:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 00:46:35 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:48:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca45a9cb9adbd6d9947ff3d4e0ddb6a548c4872b
Cr-Commit-Position: refs/heads/master@{#419350}

Powered by Google App Engine
This is Rietveld 408576698