Fix recently introduced strong-mode errors

Fix recently introduced strong-mode errors

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/ab9ba20c04fe61b3ee42f77ba49e4b36a87a4d2d

[Brian Wilkerson, 2016-09-15 17:57:43]

brianwilkerson@google.com changed reviewers:
+ jmesserly@google.com

[Brian Wilkerson, 2016-09-15 20:39:27]

friendly ping

[Jennifer Messerly, 2016-09-15 21:00:34]

lgtm... in general this does make me want to see our upwards+downwards better
integrated so we can tweak our heuristics ... but seems reasonable for now.

https://codereview.chromium.org/2344933002/diff/1/pkg/analysis_server/benchma...
File pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart (right):

https://codereview.chromium.org/2344933002/diff/1/pkg/analysis_server/benchma...
pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart:47:
Future.wait(<Future>[test.test_timing()]);
maybe put a type on "var test" above? Then it wouldn't be needed here

https://codereview.chromium.org/2344933002/diff/1/pkg/analysis_server/benchma...
pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart:107: new
List<Metric>.from(metricNames.map((name) => getMetric(name)));
any idea what happened here? it doesn't look like something that would be
affected by any recent changes.

also just noticed, it could be: metricNames.map(getMetric)

https://codereview.chromium.org/2344933002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/2344933002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:184: List<ConstantEvaluationTarget>
expectedConstants =
maybe "var" on left side so the type isn't repeated? and would fit on one line
:)

[Brian Wilkerson, 2016-09-15 21:37:27]

https://codereview.chromium.org/2344933002/diff/1/pkg/analysis_server/benchma...
File pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart (right):

https://codereview.chromium.org/2344933002/diff/1/pkg/analysis_server/benchma...
pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart:47:
Future.wait(<Future>[test.test_timing()]);
The superclass of those two classes doesn't define `test_timing`, so we get a
different error.

https://codereview.chromium.org/2344933002/diff/1/pkg/analysis_server/benchma...
pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart:107: new
List<Metric>.from(metricNames.map((name) => getMetric(name)));
> any idea what happened here?

Nope. I tried to reproduce the error and couldn't, so I reverted the change...

> also just noticed, it could be: metricNames.map(getMetric)

...except for this simplification.

https://codereview.chromium.org/2344933002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/2344933002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:184: List<ConstantEvaluationTarget>
expectedConstants =
I would, but there is a sharp pain in the back of my head every time I type that
three letter replacement for a type. :-)

[Brian Wilkerson, 2016-09-15 21:37:44]

Description was changed from

==========
Fix recently introduced strong-mode errors
==========

to

==========
Fix recently introduced strong-mode errors

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ab9ba20c04fe61b3ee42f77ba49e4b36a87a4d2d
==========

[Brian Wilkerson, 2016-09-15 21:37:46]

Committed patchset #1 (id:1) manually as
ab9ba20c04fe61b3ee42f77ba49e4b36a87a4d2d (presubmit successful).