Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 23449042: Allocation site tests aren't compatible with GcStress mode. (Closed)

Created:
7 years, 3 months ago by mvstanton
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allocation site tests aren't compatible with GcStress mode. They make assumptions about elementskind of arrays based on allocation site feedback. This feedback is highly dependent on mementos, unrooted objects placed behind arrays in the heap meant to live until the next scavenge. GcStress does many more gcs than normal, and wrecks havoc with this kind of test. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16832

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/mjsunit/allocation-site-info.js View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Hannes, "PTAL"
7 years, 3 months ago (2013-09-19 12:46:46 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/23449042/diff/1/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/23449042/diff/1/test/mjsunit/allocation-site-info.js#newcode41 test/mjsunit/allocation-site-info.js:41: %SetFlags("--gc-interval=-1") Can you try to set the flag in ...
7 years, 3 months ago (2013-09-19 12:53:36 UTC) #2
Hannes Payer (out of office)
LGTM
7 years, 3 months ago (2013-09-19 13:10:13 UTC) #3
mvstanton
thx! https://codereview.chromium.org/23449042/diff/1/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/23449042/diff/1/test/mjsunit/allocation-site-info.js#newcode41 test/mjsunit/allocation-site-info.js:41: %SetFlags("--gc-interval=-1") On 2013/09/19 12:53:36, Hannes Payer wrote: > ...
7 years, 3 months ago (2013-09-19 13:10:35 UTC) #4
mvstanton
7 years, 3 months ago (2013-09-19 13:32:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r16832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698