Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23449033: [ash] Remove Launcher::GetLauncherViewForTest() (Closed)

Created:
7 years, 3 months ago by simonhong_
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, hyojun.im_lge.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[ash] Remove Launcher::GetLauncherViewForTest() To export LauncherView, ash::test::LauncherTestAPI class is created. R=sky@chromium.org BUG=NONE TEST=ash_unittests, browser_tests, interactive_ui_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223215

Patch Set 1 #

Total comments: 2

Patch Set 2 : Initialize member variables #

Patch Set 3 : Add missing class keyword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -65 lines) Patch
M ash/ash.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/launcher/launcher.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M ash/launcher/launcher.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/launcher/launcher_unittest.cc View 1 2 chunks +74 lines, -40 lines 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A ash/test/launcher_test_api.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ash/test/launcher_test_api.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 5 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
simonhong_
Dear sky, Please take a look. Thank you. Simon.
7 years, 3 months ago (2013-09-13 05:52:34 UTC) #1
sky
LGTM https://codereview.chromium.org/23449033/diff/1/ash/launcher/launcher_unittest.cc File ash/launcher/launcher_unittest.cc (right): https://codereview.chromium.org/23449033/diff/1/ash/launcher/launcher_unittest.cc#newcode72 ash/launcher/launcher_unittest.cc:72: Launcher* launcher_; member initialize these to NULL.
7 years, 3 months ago (2013-09-13 17:12:25 UTC) #2
simonhong_
https://codereview.chromium.org/23449033/diff/1/ash/launcher/launcher_unittest.cc File ash/launcher/launcher_unittest.cc (right): https://codereview.chromium.org/23449033/diff/1/ash/launcher/launcher_unittest.cc#newcode72 ash/launcher/launcher_unittest.cc:72: Launcher* launcher_; On 2013/09/13 17:12:25, sky wrote: > member ...
7 years, 3 months ago (2013-09-13 17:21:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23449033/5001
7 years, 3 months ago (2013-09-13 17:21:59 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-13 18:01:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23449033/25001
7 years, 3 months ago (2013-09-13 18:11:52 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-14 04:54:14 UTC) #7
Message was sent while issue was closed. 
Change committed as 223215

Powered by Google App Engine
This is Rietveld 408576698