Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 23449023: Add kiosk browser tests for network configuration. (Closed)

Created:
7 years, 3 months ago by Tim Song
Modified:
7 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add kiosk browser tests for network configuration. BUG=242589 TEST=existing kiosk tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221848

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed dependency on notifications #

Patch Set 3 : Cleanup #

Patch Set 4 : Fix flakiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -44 lines) Patch
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.h View 1 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 7 chunks +30 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 3 7 chunks +249 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_display_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 1 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Tim Song
Hi Xiyuan, I updated the kiosk tests to include testing offline network configuration in kiosk ...
7 years, 3 months ago (2013-09-05 01:09:52 UTC) #1
xiyuan
https://codereview.chromium.org/23449023/diff/1/chrome/browser/chrome_notification_types.h File chrome/browser/chrome_notification_types.h (right): https://codereview.chromium.org/23449023/diff/1/chrome/browser/chrome_notification_types.h#newcode849 chrome/browser/chrome_notification_types.h:849: NOTIFICATION_CURRENT_SCREEN_CHANGED, Let's not adding new notifications. Instead, try add ...
7 years, 3 months ago (2013-09-05 02:36:10 UTC) #2
Tim Song
https://codereview.chromium.org/23449023/diff/1/chrome/browser/chrome_notification_types.h File chrome/browser/chrome_notification_types.h (right): https://codereview.chromium.org/23449023/diff/1/chrome/browser/chrome_notification_types.h#newcode849 chrome/browser/chrome_notification_types.h:849: NOTIFICATION_CURRENT_SCREEN_CHANGED, On 2013/09/05 02:36:10, xiyuan wrote: > Let's not ...
7 years, 3 months ago (2013-09-05 21:57:43 UTC) #3
xiyuan
Mostly good. Per our discussion, let's add some code to ensure each test case properly ...
7 years, 3 months ago (2013-09-05 23:26:11 UTC) #4
Tim Song
I don't think there is any need for a boilerplate scoped class. Resetting the test ...
7 years, 3 months ago (2013-09-06 18:04:38 UTC) #5
xiyuan
lgtm
7 years, 3 months ago (2013-09-06 18:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/23449023/20001
7 years, 3 months ago (2013-09-06 20:44:33 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 01:24:50 UTC) #8
Message was sent while issue was closed.
Change committed as 221848

Powered by Google App Engine
This is Rietveld 408576698