Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc

Issue 23449015: iTunes artist, album, and track names need to be escaped for slash and colon. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
diff --git a/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc b/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
index 2f1742a3566e7ead668986c9e3c20b83207975ee..3f1cd35cb0153fe4a6f897aa1a083bd9b2da4055 100644
--- a/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
+++ b/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
@@ -393,6 +393,34 @@ class ITunesDataProviderUniqueNameTest : public ITunesDataProviderTest {
DISALLOW_COPY_AND_ASSIGN(ITunesDataProviderUniqueNameTest);
};
+class ITunesDataProviderEscapeTest : public ITunesDataProviderTest {
+ public:
+ ITunesDataProviderEscapeTest() {}
+ virtual ~ITunesDataProviderEscapeTest() {}
+
+ virtual std::vector<LibraryEntry> SetUpLibrary() OVERRIDE {
+ base::FilePath track = library_dir().AppendASCII("Track:1.mp3");
+ std::vector<LibraryEntry> entries;
+ entries.push_back(LibraryEntry("Artist:/name", "Album:name/", track));
Lei Zhang 2013/08/29 23:28:38 Can we add either some more entries or another tes
vandebo (ex-Chrome) 2013/08/30 03:48:32 Done.
+ return entries;
+ }
+
+ virtual void StartTest(bool parse_success) OVERRIDE {
+ EXPECT_TRUE(parse_success);
+
+ base::FilePath track =
+ library_dir().AppendASCII("Track:1.mp3").NormalizePathSeparators();
+ EXPECT_EQ(track.value(),
+ data_provider()->GetTrackLocation(
+ "Artist__name", "Album_name_",
+ "Track_1.mp3").NormalizePathSeparators().value());
+ TestDone();
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ITunesDataProviderEscapeTest);
+};
+
IN_PROC_BROWSER_TEST_F(ITunesDataProviderBasicTest, BasicTest) {
RunTest();
}
@@ -409,4 +437,8 @@ IN_PROC_BROWSER_TEST_F(ITunesDataProviderUniqueNameTest, UniqueNameTest) {
RunTest();
}
+IN_PROC_BROWSER_TEST_F(ITunesDataProviderEscapeTest, EscapeTest) {
+ RunTest();
+}
+
} // namespace itunes

Powered by Google App Engine
This is Rietveld 408576698