Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2344893010: Fix walk graph to recurse correctly. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Fix walk graph to recurse correctly. Previously max depth would be used to see how far to load attempts, as well as how far to recurse deps. That's pretty silly. Now we use max_depth > 0 to actually restrict how far down we walk. This makes the API match its documented behavior in the protos. R=dnj@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/6ee6d7b70a20e63e1115441a424ddd039d1c6b29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M dm/appengine/deps/walk_graph.go View 4 chunks +6 lines, -3 lines 0 comments Download
M dm/appengine/deps/walk_graph_test.go View 7 chunks +3 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
iannucci
4 years, 3 months ago (2016-09-16 23:54:27 UTC) #1
Vadim Sh.
lgtm
4 years, 3 months ago (2016-09-17 00:01:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344893010/1
4 years, 3 months ago (2016-09-17 00:06:12 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:14:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/6ee6d7b70a20e63e1115441a424ddd039d1c6b29

Powered by Google App Engine
This is Rietveld 408576698