Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2344893009: Blimp: relocate thread-unsafe member getter in DropConnection code. (Closed)
Patch Set: wez feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/client/core/blimp_client_context_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 5 #ifndef BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
6 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 6 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 virtual void OnAuthTokenReceived(const std::string& client_auth_token); 77 virtual void OnAuthTokenReceived(const std::string& client_auth_token);
78 78
79 // Called when the AssignmentSource is finished getting an Assignment. Will 79 // Called when the AssignmentSource is finished getting an Assignment. Will
80 // then call |ConnectWithAssignment| to initiate the actual connection. 80 // then call |ConnectWithAssignment| to initiate the actual connection.
81 virtual void OnAssignmentReceived(AssignmentRequestResult result, 81 virtual void OnAssignmentReceived(AssignmentRequestResult result,
82 const Assignment& assignment); 82 const Assignment& assignment);
83 83
84 void RegisterFeatures(); 84 void RegisterFeatures();
85 void InitializeSettings(); 85 void InitializeSettings();
86 86
87 // Terminates the active connection held by |net_connections_|.
88 // May be called on any thread.
89 void DropConnection();
90
87 // Create IdentitySource which provides user sign in states and OAuth2 token 91 // Create IdentitySource which provides user sign in states and OAuth2 token
88 // service. 92 // service.
89 void CreateIdentitySource(); 93 void CreateIdentitySource();
90 94
91 // BlobImageSerializationProcessor::ErrorDelegate implementation. 95 // BlobImageSerializationProcessor::ErrorDelegate implementation.
92 void OnImageDecodeError() override; 96 void OnImageDecodeError() override;
93 97
94 // Provides functionality from the embedder. 98 // Provides functionality from the embedder.
95 BlimpClientContextDelegate* delegate_ = nullptr; 99 BlimpClientContextDelegate* delegate_ = nullptr;
96 100
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 136
133 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_; 137 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_;
134 138
135 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl); 139 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl);
136 }; 140 };
137 141
138 } // namespace client 142 } // namespace client
139 } // namespace blimp 143 } // namespace blimp
140 144
141 #endif // BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 145 #endif // BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | blimp/client/core/blimp_client_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698