Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/shelf_io.dart

Issue 2344893007: pkg/shelf: small fix to make analyzer happy (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/shelf_io.dart
diff --git a/lib/shelf_io.dart b/lib/shelf_io.dart
index 4991089471569e647c121dd626529e147a204c66..58fbd74f4d20747459c2a28b900429c0086cd871 100644
--- a/lib/shelf_io.dart
+++ b/lib/shelf_io.dart
@@ -116,8 +116,8 @@ Request _fromHttpRequest(HttpRequest request) {
headers[k] = v.join(',');
});
- onHijack(callback) {
- return request.response
+ void onHijack(callback) {
+ request.response
.detachSocket(writeHeaders: false)
.then((socket) => callback(socket, socket));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698