Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2344893006: MD Downloads: add "waterfall" shadow (shows when the list is scrolled) (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: add "waterfall" shadow (shows when the list is scrolled) R=tsergeant@chromium.org BUG=638405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77 Cr-Commit-Position: refs/heads/master@{#419081}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.css View 2 chunks +22 lines, -0 lines 1 comment Download
M chrome/browser/resources/md_downloads/manager.js View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
4 years, 3 months ago (2016-09-16 00:34:26 UTC) #2
tsergeant
lgtm https://codereview.chromium.org/2344893006/diff/1/chrome/browser/resources/md_downloads/manager.css File chrome/browser/resources/md_downloads/manager.css (right): https://codereview.chromium.org/2344893006/diff/1/chrome/browser/resources/md_downloads/manager.css#newcode26 chrome/browser/resources/md_downloads/manager.css:26: content: ''; Hmm, good idea. We should try ...
4 years, 3 months ago (2016-09-16 00:44:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344893006/1
4 years, 3 months ago (2016-09-16 00:52:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 02:50:48 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 02:52:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77
Cr-Commit-Position: refs/heads/master@{#419081}

Powered by Google App Engine
This is Rietveld 408576698