Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2344893005: [tracing] Introduce TraceStateObserver interface to the platform. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tracing] Introduce TraceStateObserver interface to the platform. Introduce TraceStateObserver interface along with add/remove methods to the platform. BUG=chromium:406277 Committed: https://crrev.com/ce037789264b33e3edf302fab74736537c04cf22 Cr-Commit-Position: refs/heads/master@{#39513}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M include/v8-platform.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
alph
Fadi, Jochen, could you please take a look. I'm going to use it to start/stop ...
4 years, 3 months ago (2016-09-15 23:18:53 UTC) #2
fmeawad
lgtm
4 years, 3 months ago (2016-09-15 23:43:48 UTC) #5
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/2344893005/diff/1/include/v8-platform.h File include/v8-platform.h (right): https://codereview.chromium.org/2344893005/diff/1/include/v8-platform.h#newcode170 include/v8-platform.h:170: virtual ~TraceStateObserver() {} nit. = default
4 years, 3 months ago (2016-09-19 14:23:50 UTC) #8
alph
https://codereview.chromium.org/2344893005/diff/1/include/v8-platform.h File include/v8-platform.h (right): https://codereview.chromium.org/2344893005/diff/1/include/v8-platform.h#newcode170 include/v8-platform.h:170: virtual ~TraceStateObserver() {} On 2016/09/19 14:23:50, jochen wrote: > ...
4 years, 3 months ago (2016-09-19 19:20:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344893005/20001
4 years, 3 months ago (2016-09-19 19:20:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 20:05:59 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:01:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce037789264b33e3edf302fab74736537c04cf22
Cr-Commit-Position: refs/heads/master@{#39513}

Powered by Google App Engine
This is Rietveld 408576698