Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2344893002: Fix compilation error by unused functions under ceratin build configuration. (Closed)

Created:
4 years, 3 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, fukino
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation error by unused functions under ceratin build configuration. Existing code will not build when building chromeos_unittests target following the simple chrome build instruction http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromium-browser with BOARD=x86-generic, for example. TEST=chromeos_unittest built successfully following the instruction above, and the test passed. Committed: https://crrev.com/5503269ae5822661217e13801bbd44df6fe3ddb2 Cr-Commit-Position: refs/heads/master@{#419128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chromeos/disks/disk_mount_manager_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yamaguchi
4 years, 3 months ago (2016-09-15 16:09:20 UTC) #8
satorux1
lgtm
4 years, 3 months ago (2016-09-16 07:46:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344893002/1
4 years, 3 months ago (2016-09-16 07:47:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 07:54:01 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 07:57:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5503269ae5822661217e13801bbd44df6fe3ddb2
Cr-Commit-Position: refs/heads/master@{#419128}

Powered by Google App Engine
This is Rietveld 408576698