Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2344853002: [wasm] Do proper bounds checking in the wasm interpreter for grow memory. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Do proper bounds checking in the wasm interpreter for grow memory. R=titzer@chromium.org BUG=chromium:647027 Committed: https://crrev.com/e4ebd08c644da73562490aca189c9e482b8130cb Cr-Commit-Position: refs/heads/master@{#39440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/wasm/wasm-interpreter.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ahaas
4 years, 3 months ago (2016-09-15 08:57:52 UTC) #1
titzer
lgtm
4 years, 3 months ago (2016-09-15 09:04:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344853002/1
4 years, 3 months ago (2016-09-15 09:24:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 09:26:58 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 09:27:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4ebd08c644da73562490aca189c9e482b8130cb
Cr-Commit-Position: refs/heads/master@{#39440}

Powered by Google App Engine
This is Rietveld 408576698