Revert of Magnifier border is now more visible on light backgrounds.

Revert of Magnifier border is now more visible on light backgrounds. (patchset #8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16164

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long) (/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*) ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*, ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*, std::allocator<ui::EventHandler*> >*, ui::Event*) ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
>
> Previously the partial magnifier border was difficult to see on white colored backgrounds. I add a textured layer instead of a solid color, so the border is outlined in black, so that it is visible on all backgrounds.
>
> BUG=638996
> TEST=none
>
> https://screenshot.googleplex.com/htWDLX1Bxdp
>
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996
Committed: https://crrev.com/514b86d045274ffe6ef13515c962a510cb5aca17
Cr-Commit-Position: refs/heads/master@{#418802}

[Yuta Kitamura, 2016-09-15 07:56:49]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-09-15 07:56:49]

Created Revert of Magnifier border is now more visible on light backgrounds.

[commit-bot: I haz the power, 2016-09-15 07:57:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 07:57:53]

Description was changed from

==========
Revert of Magnifier border is now more visible on light backgrounds. (patchset
#8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long)
(/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in
ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*)
ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive
ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in
ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*,
ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in
ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*,
std::allocator<ui::EventHandler*> >*, ui::Event*)
ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
> 
> Previously the partial magnifier border was difficult to see on white colored
backgrounds. I add a textured layer instead of a solid color, so the border is
outlined in black, so that it is visible on all backgrounds.
> 
> BUG=638996
> TEST=none
> 
> https://screenshot.googleplex.com/htWDLX1Bxdp
> 
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996
==========

to

==========
Revert of Magnifier border is now more visible on light backgrounds. (patchset
#8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long)
(/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in
ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*)
ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive
ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in
ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*,
ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in
ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*,
std::allocator<ui::EventHandler*> >*, ui::Event*)
ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
> 
> Previously the partial magnifier border was difficult to see on white colored
backgrounds. I add a textured layer instead of a solid color, so the border is
outlined in black, so that it is visible on all backgrounds.
> 
> BUG=638996
> TEST=none
> 
> https://screenshot.googleplex.com/htWDLX1Bxdp
> 
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996
==========

[commit-bot: I haz the power, 2016-09-15 07:57:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 08:01:27]

Description was changed from

==========
Revert of Magnifier border is now more visible on light backgrounds. (patchset
#8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long)
(/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in
ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*)
ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive
ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in
ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*,
ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in
ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*,
std::allocator<ui::EventHandler*> >*, ui::Event*)
ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
> 
> Previously the partial magnifier border was difficult to see on white colored
backgrounds. I add a textured layer instead of a solid color, so the border is
outlined in black, so that it is visible on all backgrounds.
> 
> BUG=638996
> TEST=none
> 
> https://screenshot.googleplex.com/htWDLX1Bxdp
> 
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996
==========

to

==========
Revert of Magnifier border is now more visible on light backgrounds. (patchset
#8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long)
(/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in
ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*)
ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive
ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in
ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*,
ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in
ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*,
std::allocator<ui::EventHandler*> >*, ui::Event*)
ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
>
> Previously the partial magnifier border was difficult to see on white colored
backgrounds. I add a textured layer instead of a solid color, so the border is
outlined in black, so that it is visible on all backgrounds.
>
> BUG=638996
> TEST=none
>
> https://screenshot.googleplex.com/htWDLX1Bxdp
>
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996

Committed: https://crrev.com/514b86d045274ffe6ef13515c962a510cb5aca17
Cr-Commit-Position: refs/heads/master@{#418802}
==========

[commit-bot: I haz the power, 2016-09-15 08:01:28]

Patchset 1 (id:??) landed as
https://crrev.com/514b86d045274ffe6ef13515c962a510cb5aca17
Cr-Commit-Position: refs/heads/master@{#418802}