Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2344813002: Revert "[DevTools] Make log agent optional." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.Object} 9 * @extends {WebInspector.Object}
10 */ 10 */
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 * @param {string} name 183 * @param {string} name
184 * @param {number} capabilitiesMask 184 * @param {number} capabilitiesMask
185 * @param {!InspectorBackendClass.Connection} connection 185 * @param {!InspectorBackendClass.Connection} connection
186 * @param {?WebInspector.Target} parentTarget 186 * @param {?WebInspector.Target} parentTarget
187 * @return {!WebInspector.Target} 187 * @return {!WebInspector.Target}
188 */ 188 */
189 createTarget: function(name, capabilitiesMask, connection, parentTarget) 189 createTarget: function(name, capabilitiesMask, connection, parentTarget)
190 { 190 {
191 var target = new WebInspector.Target(this, name, capabilitiesMask, conne ction, parentTarget); 191 var target = new WebInspector.Target(this, name, capabilitiesMask, conne ction, parentTarget);
192 192
193 var logAgent = target.hasBrowserCapability() ? target.logAgent() : null;
194
195 /** @type {!WebInspector.ConsoleModel} */ 193 /** @type {!WebInspector.ConsoleModel} */
196 target.consoleModel = new WebInspector.ConsoleModel(target, logAgent); 194 target.consoleModel = new WebInspector.ConsoleModel(target);
197 /** @type {!WebInspector.RuntimeModel} */ 195 /** @type {!WebInspector.RuntimeModel} */
198 target.runtimeModel = new WebInspector.RuntimeModel(target); 196 target.runtimeModel = new WebInspector.RuntimeModel(target);
199 197
200 var networkManager = null; 198 var networkManager = null;
201 var resourceTreeModel = null; 199 var resourceTreeModel = null;
202 if (target.hasNetworkCapability()) 200 if (target.hasNetworkCapability())
203 networkManager = new WebInspector.NetworkManager(target); 201 networkManager = new WebInspector.NetworkManager(target);
204 if (networkManager && target.hasDOMCapability()) { 202 if (networkManager && target.hasDOMCapability()) {
205 resourceTreeModel = new WebInspector.ResourceTreeModel(target, netwo rkManager, WebInspector.SecurityOriginManager.fromTarget(target)); 203 resourceTreeModel = new WebInspector.ResourceTreeModel(target, netwo rkManager, WebInspector.SecurityOriginManager.fromTarget(target));
206 new WebInspector.NetworkLog(target, resourceTreeModel, networkManage r); 204 new WebInspector.NetworkLog(target, resourceTreeModel, networkManage r);
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 /** 376 /**
379 * @param {!WebInspector.Target} target 377 * @param {!WebInspector.Target} target
380 */ 378 */
381 targetRemoved: function(target) { }, 379 targetRemoved: function(target) { },
382 } 380 }
383 381
384 /** 382 /**
385 * @type {!WebInspector.TargetManager} 383 * @type {!WebInspector.TargetManager}
386 */ 384 */
387 WebInspector.targetManager = new WebInspector.TargetManager(); 385 WebInspector.targetManager = new WebInspector.TargetManager();
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698