Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2344813002: Revert "[DevTools] Make log agent optional." (Closed)

Created:
4 years, 3 months ago by shimazu
Modified:
4 years, 3 months ago
Reviewers:
eostroukhov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[DevTools] Make log agent optional." This reverts commit d0125b8fc7acf574d14b7e0dad739d814c8593c5. Reason: Warnings from ServiceWorkerGlobalScope doesn't show up in devtools' console BUG=594160 TBR=eostroukhov, pfeldman Committed: https://crrev.com/bdf22b26c6d9a10f2c8bfc956f59b6c482663d8e Cr-Commit-Position: refs/heads/master@{#418793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 3 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
shimazu
4 years, 3 months ago (2016-09-15 05:28:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344813002/1
4 years, 3 months ago (2016-09-15 05:28:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 06:36:06 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 06:38:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf22b26c6d9a10f2c8bfc956f59b6c482663d8e
Cr-Commit-Position: refs/heads/master@{#418793}

Powered by Google App Engine
This is Rietveld 408576698