ash/common/wm_root_window_controller.cc - Issue 2344783002: Wires up WmWindowMus::SetBoundsInScreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/wm_root_window_controller.cc

Issue 2344783002: Wires up WmWindowMus::SetBoundsInScreen() (Closed)

Patch Set: feedback2 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/wm_root_window_controller.cc

diff --git a/ash/common/wm_root_window_controller.cc b/ash/common/wm_root_window_controller.cc

index 98e4aefb418599356a61512cd07d7f4dbcd162c5..f2c512b6e692c98feb219c5f1941d0985105c1b8 100644

--- a/ash/common/wm_root_window_controller.cc

+++ b/ash/common/wm_root_window_controller.cc

@@ -208,7 +208,7 @@ void WmRootWindowController::CreateContainers() {

shelf_container->SetSnapsChildrenToPhysicalPixelBoundary();

shelf_container->SetBoundsInScreenBehaviorForChildren(

WmWindow::BoundsInScreenBehavior::USE_SCREEN_COORDINATES);

- shelf_container->SetDescendantsStayInSameRootWindow(true);

+ shelf_container->SetLockedToRoot(true);

WmWindow* panel_container =

CreateContainer(kShellWindowId_PanelContainer, "PanelContainer",

@@ -223,7 +223,7 @@ void WmRootWindowController::CreateContainers() {

shelf_bubble_container->SetSnapsChildrenToPhysicalPixelBoundary();

shelf_bubble_container->SetBoundsInScreenBehaviorForChildren(

WmWindow::BoundsInScreenBehavior::USE_SCREEN_COORDINATES);

- shelf_bubble_container->SetDescendantsStayInSameRootWindow(true);

+ shelf_bubble_container->SetLockedToRoot(true);

WmWindow* app_list_container =

CreateContainer(kShellWindowId_AppListContainer, "AppListContainer",

@@ -266,7 +266,7 @@ void WmRootWindowController::CreateContainers() {

status_container->SetSnapsChildrenToPhysicalPixelBoundary();

status_container->SetBoundsInScreenBehaviorForChildren(

WmWindow::BoundsInScreenBehavior::USE_SCREEN_COORDINATES);

- status_container->SetDescendantsStayInSameRootWindow(true);

+ status_container->SetLockedToRoot(true);

WmWindow* settings_bubble_container =

CreateContainer(kShellWindowId_SettingBubbleContainer,

@@ -275,7 +275,7 @@ void WmRootWindowController::CreateContainers() {

settings_bubble_container->SetSnapsChildrenToPhysicalPixelBoundary();

settings_bubble_container->SetBoundsInScreenBehaviorForChildren(

WmWindow::BoundsInScreenBehavior::USE_SCREEN_COORDINATES);

- settings_bubble_container->SetDescendantsStayInSameRootWindow(true);

+ settings_bubble_container->SetLockedToRoot(true);

WmWindow* virtual_keyboard_parent_container = CreateContainer(

kShellWindowId_ImeWindowParentContainer, "VirtualKeyboardParentContainer",

« no previous file with comments | « ash/common/wm/window_positioning_utils.cc ('k') | ash/common/wm_window.h » ('j') | no next file with comments »