Support for string value

Support for string value

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266175

[nduca, 2014-04-11 23:16:12]

looks solid, go for tests. make sure to add string cases to each of the results
object unittests so we can be sure they can handle strings [its a bit sad that
this is how our tests work but thats how it is right now]

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
File tools/telemetry/telemetry/value/list_of_string_values.py (right):

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
tools/telemetry/telemetry/value/list_of_string_values.py:42: return
self.values[0]
i think you need to return None here and validate that the callers can handle
this.

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
File tools/telemetry/telemetry/value/string.py (right):

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
tools/telemetry/telemetry/value/string.py:14: StringValue(page,
'num_dom_elements', 'count', num_elements)
this text seems wrong :)

[nduca, 2014-04-24 21:32:04]

this would be really cool to get landed. any progress on tests?

[chromium-reviews, 2014-04-24 21:33:19]

Sorry for the delay, will send the updated patch with the tests.

Satya


On Thu, Apr 24, 2014 at 2:32 PM, <nduca@chromium.org> wrote:

> this would be really cool to get landed. any progress on tests?
>
> https://codereview.chromium.org/234473002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-04-25 00:30:25]

How to just run a particular unittest locally.

Satya


On Thu, Apr 24, 2014 at 2:32 PM, Satyanarayana Manyam <
satyanarayana@google.com> wrote:

> Sorry for the delay, will send the updated patch with the tests.
>
> Satya
>
>
> On Thu, Apr 24, 2014 at 2:32 PM, <nduca@chromium.org> wrote:
>
>> this would be really cool to get landed. any progress on tests?
>>
>> https://codereview.chromium.org/234473002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dtu, 2014-04-25 00:41:40]

On 2014/04/25 00:30:25, chromium-reviews_chromium.org wrote:
> How to just run a particular unittest locally.
> 
> Satya
> 
> 
> On Thu, Apr 24, 2014 at 2:32 PM, Satyanarayana Manyam <
> mailto:satyanarayana@google.com> wrote:
> 
> > Sorry for the delay, will send the updated patch with the tests.
> >
> > Satya
> >
> >
> > On Thu, Apr 24, 2014 at 2:32 PM, <mailto:nduca@chromium.org> wrote:
> >
> >> this would be really cool to get landed. any progress on tests?
> >>
> >> https://codereview.chromium.org/234473002/
> >>
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

tools/telemetry/run_tests test_name

[nduca, 2014-04-25 00:41:49]

./tools/telemetry/run_tests <some part of test name>

That'll run any test that matches the passed stirng


On Thu, Apr 24, 2014 at 5:30 PM, Satyanarayana Manyam <
satyanarayana@google.com> wrote:

> How to just run a particular unittest locally.
>
> Satya
>
>
> On Thu, Apr 24, 2014 at 2:32 PM, Satyanarayana Manyam <
> satyanarayana@google.com> wrote:
>
>> Sorry for the delay, will send the updated patch with the tests.
>>
>> Satya
>>
>>
>> On Thu, Apr 24, 2014 at 2:32 PM, <nduca@chromium.org> wrote:
>>
>>> this would be really cool to get landed. any progress on tests?
>>>
>>> https://codereview.chromium.org/234473002/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Satyanarayana N H Manyam, 2014-04-25 01:22:31]

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
File tools/telemetry/telemetry/value/list_of_string_values.py (right):

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
tools/telemetry/telemetry/value/list_of_string_values.py:42: return
self.values[0]
On 2014/04/11 23:16:13, nduca wrote:
> i think you need to return None here and validate that the callers can handle
> this.

Done.

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
File tools/telemetry/telemetry/value/string.py (right):

https://codereview.chromium.org/234473002/diff/100001/tools/telemetry/telemet...
tools/telemetry/telemetry/value/string.py:14: StringValue(page,
'num_dom_elements', 'count', num_elements)
On 2014/04/11 23:16:13, nduca wrote:
> this text seems wrong :)

Done.

[nduca, 2014-04-25 01:29:18]

lgtm

[Satyanarayana N H Manyam, 2014-04-25 01:41:54]

The CQ bit was checked by satyanarayana@google.com

[commit-bot: I haz the power, 2014-04-25 02:03:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satyanarayana@google.com/234473002/160001

[commit-bot: I haz the power, 2014-04-25 09:27:13]

Change committed as 266175

[chromium-reviews, 2014-08-04 21:37:30]

A telemetry values question, 3 months later: What do we gain from having 
separate StringValues and ScalarValues. Could we just support strings in 
ScalarValues?

Most of the code is shared between these classes. It looks like the only 
difference is the 'assert isinstance(v, numbers.Number)' versus 'assert 
isinstance(v, basestring)' and the GetRepresentativeNumber in the 
ListOf*Values classes. The only place I see StringValue being used right 
now is in page_runner unittests and TimelineBasedMeasurement.

- Ari

On Friday, April 25, 2014 2:27:14 AM UTC-7, commi...@chromium.org wrote:
>
> Change committed as 266175 
>
> https://codereview.chromium.org/234473002/ 
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.