Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2344723004: Introduce PREPARE_FOR_EXECUTION_WITH_CONTEXT_IN_RUNTIME_CALL_STATS_SCOPE (Closed)

Created:
4 years, 3 months ago by lpy
Modified:
4 years, 3 months ago
Reviewers:
fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce PREPARE_FOR_EXECUTION_WITH_CONTEXT_IN_RUNTIME_CALL_STATS_SCOPE Previously, macro like PREPARE_FOR_EXECUTION_WITH_CALLBACK will end up calling LOG_API, where we create a runtime call timer scope when we enable tracing with runtime call stats, however since the flag will be enabled after calling TRACE_EVENT_CALL_STATS_SCOPED, this will end up with incorrect timestamp. Thus, we introduce a new macro PREPARE_FOR_EXECUTION_WITH_CONTEXT_IN_RUNTIME_CALL_STATS_SCOPE, which will call TRACE_EVENT_CALL_STATS_SCOPED inside it. BUG=v8:5089 Committed: https://crrev.com/9df94139d8e240762e9bc9f29b86648ae78f7627 Cr-Commit-Position: refs/heads/master@{#39458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M src/api.cc View 6 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
lpy
PTAL. We are using `isolate` when we create a tracing scope for runtime call stats, ...
4 years, 3 months ago (2016-09-15 23:02:53 UTC) #4
lpy
The timestamp is now reasonable, please take a look at this screen shot. (chromium.org domain) ...
4 years, 3 months ago (2016-09-15 23:08:59 UTC) #5
Camillo Bruni
lgtm
4 years, 3 months ago (2016-09-15 23:42:05 UTC) #8
fmeawad
lgtm
4 years, 3 months ago (2016-09-15 23:47:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344723004/1
4 years, 3 months ago (2016-09-16 00:09:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 00:11:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:11:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9df94139d8e240762e9bc9f29b86648ae78f7627
Cr-Commit-Position: refs/heads/master@{#39458}

Powered by Google App Engine
This is Rietveld 408576698