Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2344723003:
[telemetry] Disable the CPU tracing agent for BattOr benchmarks (Closed)
|
Created:
4 years, 3 months ago by charliea (OOO until 10-5) Modified:
4 years, 3 months ago Reviewers:
sullivan CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[telemetry] Disable the CPU tracing agent for BattOr benchmarks
It's causing indefinite hangs on https://goo.gl/EJZ4HY
BUG=647443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/6c2fec5404e728502940032a8837a2bc7223d786
Cr-Commit-Position: refs/heads/master@{#420360}
Patch Set 1 #Patch Set 2 : Sync to head #Messages
Total messages: 23 (14 generated)
Description was changed from ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 ========== to ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
charliea@chromium.org changed reviewers: + sullivan@chromium.org
lgtm
The CQ bit was checked by charliea@chromium.org
The CQ bit was unchecked by charliea@chromium.org
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 ==========
Description was changed from ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 ========== to ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Patchset #2 (id:20001) has been deleted
Manually landing this: it's a one line fix that's easy to understand and shouldn't under any circumstance break anything.
On 2016/09/22 at 13:37:24, charliea wrote: > Manually landing this: it's a one line fix that's easy to understand and shouldn't under any circumstance break anything. No need to land this in a rush, I guess: the Windows builders are down anyhow. Submitting manually.
Description was changed from ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org Link to the patchset: https://codereview.chromium.org/2344723003/#ps40001 (title: "Sync to head")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/6c2fec5404e728502940032a8837a2bc7223d786 Cr-Commit-Position: refs/heads/master@{#420360} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6c2fec5404e728502940032a8837a2bc7223d786 Cr-Commit-Position: refs/heads/master@{#420360}
Message was sent while issue was closed.
Description was changed from ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/6c2fec5404e728502940032a8837a2bc7223d786 Cr-Commit-Position: refs/heads/master@{#420360} ========== to ========== [telemetry] Disable the CPU tracing agent for BattOr benchmarks It's causing indefinite hangs on https://goo.gl/EJZ4HY BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/6c2fec5404e728502940032a8837a2bc7223d786 Cr-Commit-Position: refs/heads/master@{#420360} ========== |
