Issue 2344713002: [Offline Pages] Adds duplicate detection metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2344713002: [Offline Pages] Adds duplicate detection metrics. (Closed)

Created:
4 years, 3 months ago by dewittj

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Offline Pages] Adds duplicate detection metrics. We want to know whether the UI for showing page downloads as starting is sufficient to let the user know that something is happening. The hypothesis is that if users get too many duplicate pages then they aren't noticing that the pages are getting saved on the first button click. BUG=643748 Review-Url: https://codereview.chromium.org/2314273003 Cr-Commit-Position: refs/heads/master@{#418331} (cherry picked from commit 1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae)

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -2 lines)			Patch
M	components/offline_pages/offline_page_model_impl.cc	View	4 chunks	+75 lines, -2 lines	0 comments	Download
M	components/offline_pages/offline_page_model_impl_unittest.cc	View	2 chunks	+43 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dewittj

4 years, 3 months ago (2016-09-15 17:44:35 UTC) #1

Description was changed from

==========
[Offline Pages] Adds duplicate detection metrics.

We want to know whether the UI for showing page downloads as starting
is sufficient to let the user know that something is happening.  The
hypothesis is that if users get too many duplicate pages then they aren't
noticing that the pages are getting saved on the first button click.

BUG=643748

Review-Url: https://codereview.chromium.org/2314273003
Cr-Commit-Position: refs/heads/master@{#418331}
(cherry picked from commit 1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae)
==========

to

==========
[Offline Pages] Adds duplicate detection metrics.

We want to know whether the UI for showing page downloads as starting
is sufficient to let the user know that something is happening.  The
hypothesis is that if users get too many duplicate pages then they aren't
noticing that the pages are getting saved on the first button click.

BUG=643748

Review-Url: https://codereview.chromium.org/2314273003
Cr-Commit-Position: refs/heads/master@{#418331}
(cherry picked from commit 1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages