Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 23447035: Reland r16751 with fix (Closed)

Created:
7 years, 3 months ago by Bangfu
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

Fixed a bug in CopyBytes() and new test cases for ARM macro assembler TEST=cctest/test-macro-assembler-arm R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16873

Patch Set 1 #

Total comments: 1

Patch Set 2 : unconditional branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -7 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -1 line 0 comments Download
A test/cctest/test-macro-assembler-arm.cc View 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc#newcode3224 src/arm/macro-assembler-arm.cc:3224: b(ne, &align_loop_1); Shouldn't this be an unconditional branch to ...
7 years, 3 months ago (2013-09-20 10:31:20 UTC) #1
Bangfu
On 2013/09/20 10:31:20, Benedikt Meurer wrote: > https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc > File src/arm/macro-assembler-arm.cc (right): > > https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc#newcode3224 ...
7 years, 3 months ago (2013-09-20 10:47:12 UTC) #2
Bangfu
On 2013/09/20 10:47:12, Bangfu wrote: > On 2013/09/20 10:31:20, Benedikt Meurer wrote: > > https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc ...
7 years, 3 months ago (2013-09-20 13:24:05 UTC) #3
Benedikt Meurer
Ok, LGTM.
7 years, 3 months ago (2013-09-20 13:37:00 UTC) #4
Benedikt Meurer
7 years, 3 months ago (2013-09-23 08:07:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698