Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 23447032: Set USE(NATIVE_FULLSCREEN_VIDEO) in config.h instead of a gyp file (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Set USE(NATIVE_FULLSCREEN_VIDEO) in config.h instead of a gyp file as the gyp build system does not need knowledge about this configuration. BUG=286578 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/config.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
..seems quite straightforward..
7 years, 3 months ago (2013-09-20 01:11:23 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-20 15:59:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23447032/1
7 years, 3 months ago (2013-09-20 15:59:59 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 17:28:05 UTC) #4
Message was sent while issue was closed.
Change committed as 158126

Powered by Google App Engine
This is Rietveld 408576698